Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

findrx does not get stored in history object #3150

Closed
lwellerastro opened this issue Mar 7, 2019 · 11 comments
Closed

findrx does not get stored in history object #3150

lwellerastro opened this issue Mar 7, 2019 · 11 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@lwellerastro
Copy link
Contributor

ISIS version(s) affected: 3.6.0

Description
There is no history of running findrx on an image when cathist is run afterwards.

How to reproduce
Run findrx on an image which has reseau points, then run cathist - findrx does not appear in the history.

Possible Solution
Add a history object (or whatever it is) to findrx

Additional context
Data: /work/users/lweller/Findrx/c1631247.lev0.cub
There is a file named norx_c1631247.lev0.cub where findrx hasn't been run if you need it.

Processing steps as follows:
voy2isis from=/pds_san/PDS_Archive/Voyager/vg_0017/europa/c1631xxx/c1631247.imq to=c1631247.lev0.cub
spiceinit from=c1631247.lev0.cub attach=true extra=/usgs/cpkgs/isis3/data/base/kernels/pck/pck00010_msgr_v23.tpc
findrx from=c1631247.lev0.cub

Cathist run:
cathist from=c1631247.lev0.cub mode=brief

voy2isis from=/pds_san/PDS_Archive/Voyager/vg_0017/europa/c1631xxx/c1631247.imq to=c1631247.lev0.cub
spiceinit from=c1631247.lev0.cub web=false attach=true cksmithed=FALSE ckrecon=TRUE ckpredicted=FALSE cknadir=FALSE spksmithed=FALSE spkrecon=TRUE spkpredicted=FALSE extra=/usgs/cpkgs/isis3/data/base/kernels/pck/pck00010_msgr_v23.tpc shape=SYSTEM startpad=0.0 endpad=0.0 url=https://services.isis.astrogeology.usgs.gov/cgi-bin/spiceinit.cgi port=443

@jessemapel jessemapel added bug Something isn't working good first issue Good for newcomers labels Mar 7, 2019
@jessemapel
Copy link
Contributor

This should be a very easy fix and may be good for new developers.

@jlaura
Copy link
Collaborator

jlaura commented Mar 7, 2019

tagging 3.7.0 so that it is on the radar when we schedule that we should have a support sprint scheduled before 3.7.0 is RCed. @USGSsakins

@jlaura jlaura added this to the 3.7.0 milestone Mar 7, 2019
@lwellerastro
Copy link
Contributor Author

This is super low priority. I just discovered it while looking at the processing history of one of my Voyager images and realized findrx didn't make it. It doesn't affect the work in the least bit. There are likely more important issues to address than this. I was just reporting a bug.

@jessemapel
Copy link
Contributor

@lwellerastro This may be a good opportunity for our new developers to make a small change and interact with the support process.

@kaitlyndlee
Copy link
Contributor

I did something similar with sumspice. Might be helpful to check out: #2476

@jlaura jlaura added the in progress doing the things label Mar 25, 2019
@kaitlyndlee
Copy link
Contributor

@lwellerastro Testing build at /work/projects/isis/latest/m03150/ using the shared conda env isis3CentOS7.

@jlaura
Copy link
Collaborator

jlaura commented Mar 25, 2019

@kdl222 Instead of a testing build, can you reproduce without failure the process above? If so, we should get a code review, merge into dev and close. That way we are not bottlenecking on someone to test or asking someone who is working on another project to test. Thanks!

@jlaura
Copy link
Collaborator

jlaura commented Mar 25, 2019

@kdl222 We should also do a 3.6.3 release on this. We can talk tomorrow at the standup and have a plan on this. @jessemapel can you also think about how we want to get these bug fix builds merged and pushed when doing a support sprint like we are now?

@jessemapel
Copy link
Contributor

@jlaura We can do one bug fix release at the end of the sprint. Then, pull off the release candidate fro 3.7.0

@jlaura
Copy link
Collaborator

jlaura commented Mar 26, 2019

👍 See https://astrodiscuss.usgs.gov/t/support-sprints-and-bug-releases/133 for a better place to discuss this (I think?).

@kaitlyndlee
Copy link
Contributor

@jlaura I can reproduce the process without failure. I opened a PR for the changes.

@kaitlyndlee kaitlyndlee removed the in progress doing the things label Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants