Oblique Detector Resolution Should Use Local Emission Angle

[KrisBecker]

ISIS version(s) affected: All

Note the OSIRIS-REx team has a custom version of ISIS we have been maintaining and have modified code to address issues we have encountered working with small irregular bodies.

Description

The oblique detector resolution that is being calculated in the Camera::ObliqueDetectorResolution() class uses the emission angle computed from the ellipsoid model. We changed from using the ellipsoid model to instead apply the DEM/shape model so that the local emission angle can be used.

Using the local emission angle provides a much better indication of the oblique detector resolution because if takes into account surface topography.

This also affects phocube oblique detector resolution backplane as well (in a non-backward compatible way, so a new option was added to compute the old oblique detector resolution) which I could also submit for changes. Also, as a side affect, any other computation involving the ObliqueDetectorResolution, such as ObliqueSampleResolution and ObliqueLineResolution, are also affected.

How to reproduce

Applications such as phocube, camstats, campt and caminfo can provide examples of this data value.

Possible Solution

We can provide a PR/code that has this modification.

Additional context

[jessemapel]

Why this is important

The oblique detector resolution is suppose to be a more accurate measurement of the resolution. So, we should use the most accurate surface model available. For irregular bodies, there can be large variations in the surface normal, and thus the emission angle. In these situations, the ellipsoid based emission angle is insufficient.

[ascbot]

I am a bot that cleans up old issues that do not have activity.

This issue has not received feedback in the last six months. I am going to add the inactive label to
this issue. If this is still a pertinent issue, please add a comment or add an emoji to an existing comment.

I will post again in five months with another reminder and will close this issue on it's birthday unless it has
some activity.

[jessemapel]

This is still outstanding

[github-actions]

Thank you for your contribution!

Unfortunately, this issue hasn't received much attention lately, so it is labeled as 'stale.'

If no additional action is taken, this issue will be automatically closed in 180 days.