Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LunarLambertEmperical not working properly in Photomet #3608

Closed
volcanopele opened this issue Dec 16, 2019 · 4 comments
Closed

LunarLambertEmperical not working properly in Photomet #3608

volcanopele opened this issue Dec 16, 2019 · 4 comments
Assignees
Labels
Missions Issues which are a priority for missions

Comments

@volcanopele
Copy link

ISIS version(s) affected: 3.9

Description
Using Photomet on a batch of CaSSIS Images. Photometric model used is LunarLambertEmpirical. Parameters in PVL files generated by phoempglobal . I get several PROGRAMMER ERRORS:

**PROGRAMMER ERROR** Evaluate() - Unable to evaluate the function at the point a = 0.0.
**PROGRAMMER ERROR** InsideDomain() - Unable to compute domain boundaries.
**PROGRAMMER ERROR** DomainMinimum() - Unable to calculate the domain minimum for the data set.
**PROGRAMMER ERROR** ValidateDataSet() - cspline-clamped interpolation requires a minimum of 3 data points - currently have 1.

How to reproduce

Code used, Can provide images for testing:

phoempglobal to=NIR_lunarlambert.pvl phtname=HAPKEHEN wh=0.72 hh=0.005 b0=0.755 theta=30 hg1=0.213 hg2=1 nph=40 emamax_pcoeff=1 model=LUNARLAMBERT
phoempglobal to=RED_lunarlambert.pvl phtname=HAPKEHEN wh=0.723 hh=0.011 b0=0.70 theta=30 hg1=0.213 hg2=1 nph=40 emamax_pcoeff=1 model=LUNARLAMBERT 
phoempglobal to=PAN_lunarlambert.pvl phtname=HAPKEHEN wh=0.69 hh=0.017 b0=0.55 theta=30 hg1=0.213 hg2=1 nph=40 emamax_pcoeff=1 model=LUNARLAMBERT
phoempglobal to=BLU_lunarlambert.pvl phtname=HAPKEHEN wh=0.185 hh=0.062 b0=1.00 theta=30 hg1=0.145 hg2=1 nph=40 emamax_pcoeff=1 model=LUNARLAMBERT

photomet from=\$1D1.cub to=\$1P1.cub frompvl=/data/cassis/users/perry/data/photometrytest/NIR_lunarlambert.pvl anglesource=backplane normname=albedoatm phtname=LUNARLAMBERTEMPIRICAL atmname=hapkeatm1 nulneg=no wha=0.925 hga=0.679 tau=$TAU tauref=0 hnorm=0.003 incref=0 -batchlist=nir_image_name.lis
photomet from=\$1D1.cub to=\$1P1.cub frompvl=/data/cassis/users/perry/data/photometrytest/RED_lunarlambert.pvl anglesource=backplane normname=albedoatm phtname=LUNARLAMBERTEMPIRICAL atmname=hapkeatm1 nulneg=no wha=0.922 hga=0.675 tau=$TAU tauref=0 hnorm=0.003 incref=0 -batchlist=red_image_name.lis
photomet from=\$1D1.cub to=\$1P1.cub frompvl=/data/cassis/users/perry/data/photometrytest/PAN_lunarlambert.pvl anglesource=backplane normname=albedoatm phtname=LUNARLAMBERTEMPIRICAL atmname=hapkeatm1 nulneg=no wha=0.940 hga=0.653 tau=$TAU tauref=0 hnorm=0.003 incref=0 -batchlist=pan_image_name.lis
photomet from=\$1D1.cub to=\$1P1.cub frompvl=/data/cassis/users/perry/data/photometrytest/BLU_lunarlambert.pvl anglesource=backplane normname=albedoatm phtname=LUNARLAMBERTEMPIRICAL atmname=hapkeatm1 nulneg=no wha=0.724 hga=0.746 tau=$BLUETAU tauref=0 hnorm=0.003 incref=0 -batchlist=blu_image_name.lis

Possible Solution

Additional context

@jlaura jlaura added the Missions Issues which are a priority for missions label Dec 16, 2019
@krlberry krlberry self-assigned this Dec 16, 2019
@krlberry
Copy link
Contributor

@volcanopele Could you send images for testing to me at [email protected]? I can't reproduce this with some arbitrary CaSSIS images I tried to test with. Also, what values are $TAU and $BLUETAU in your example above?

@krlberry
Copy link
Contributor

Data received, thanks!

@krlberry
Copy link
Contributor

#3614 should fix the problem described in this ticket, but I just noticed that MinnaertEmpirical has the same failure mode, and could be fixed the same way. @jlaura does it make sense to add this fix as part of this ticket, or to create a new ticket?

@jlaura
Copy link
Collaborator

jlaura commented Dec 30, 2019

@kberryUSGS We should open a new ticket and label as missions. Can we close this issue with #3614 being merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Missions Issues which are a priority for missions
Projects
None yet
Development

No branches or pull requests

3 participants