Refactor cnetdiff to be callable and migrate Makefile tests to gtest format. #5322
Comments
kledmundson
added a commit
to kledmundson/ISIS3
that referenced
this issue
Oct 31, 2023
… tests have been removed and replace by gtests. Addresses DOI-USGS#5322.
12 tasks
kledmundson
added a commit
to kledmundson/ISIS3
that referenced
this issue
Nov 1, 2023
… "Changed" section per reviewer suggestion. Addresses DOI-USGS#5322.
kledmundson
added a commit
to kledmundson/ISIS3
that referenced
this issue
Nov 1, 2023
…reviewer suggestion. Addresses DOI-USGS#5322.
kledmundson
added a commit
to kledmundson/ISIS3
that referenced
this issue
Nov 1, 2023
… add PvlGroups to Pvl. Per reviewer suggestion. Addresses DOI-USGS#5322.
kledmundson
added a commit
to kledmundson/ISIS3
that referenced
this issue
Nov 2, 2023
acpaquette
pushed a commit
that referenced
this issue
Nov 6, 2023
… tests have been removed and replaced by gtests. (#5323) * The cnetedit applciation has been refactored to be callable; Makefile tests have been removed and replace by gtests. Addresses #5322. * Moved CHANGELOG.md entry for cnetdiff changes from "Added" section to "Changed" section per reviewer suggestion. Addresses #5322. * Reverted back to original ControlNetDiff source and header files per reviewer suggestion. Addresses #5322. * Changes to cnetdiff.cpp and main.cpp to use the addLogGroup method to add PvlGroups to Pvl. Per reviewer suggestion. Addresses #5322. * Put back line erroneously removed in CHANGELOG.md, per review. Addresses #5322.
|
Closed as of #5323 |
AustinSanders
added a commit
that referenced
this issue
Dec 6, 2023
* Cnetthinner application bug fix resolving divide by zero in CnetManager.cpp. (#5356) * Bug fix for a divide by zero in CnetManager.cpp. Additionally, the cnetthinner app has been converted to a callable function and Makefile tests converted to gtests. Addresses #5354. * Updated CHANGELOG.md. Addresses #5354. * Minor change to cnetthinner.xml. Addresses #5354. * Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format. Fixes #3621. (#5175) * Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format * Updated CHANGELOG * Dawn Target Translation Fix (#5294) * Fixes dawn target translation for CERES images * Added Changelog entry * CSM Camera Qview Try Catches (#5295) * Fix errors when using CSM camera in qview * Added Changelog entry * Fixes CSV parsing in shadowtau (#5316) * Fixes CSV parsing in shadowtau * Addressed PR feedback * Error Report Fix for Program Launcher (#5331) * Removed line that gets class, it is derived from the code * Added more detailed error around itime not finding the leapsecond kernel * Added changelog entry * Updated trimfilter to correctly use high/low filters (#5340) * Added high/low filters to trimfilter * Updated changelog * Updated changelog --------- Co-authored-by: acpaquette <[email protected]> * corrected calibration inclusion filter (needed ,) (#5357) * corrected calibration inclusion filter (needed ,) * changelog entry downloadIsisData fix * Updated changelog * Updated changelog * Cnetthinner application bug fix resolving divide by zero in CnetManager.cpp. (#5356) * Bug fix for a divide by zero in CnetManager.cpp. Additionally, the cnetthinner app has been converted to a callable function and Makefile tests converted to gtests. Addresses #5354. * Updated CHANGELOG.md. Addresses #5354. * Minor change to cnetthinner.xml. Addresses #5354. * The cnetedit application has been refactored to be callable; Makefile tests have been removed and replaced by gtests (#5348) * The cnetedit application has been refactored to be callable; Makefile tests have been migrated to gtest format. Addresses #5346. * Removed extraneous variables from FunctionalTestsCnetedit.cpp. Addresses #5346. * Updated gtests; replace cubes with labels. Addresses #5346. * Per review cleaned up sloppy spacing; made global variables static in cnetedit.cpp to avoid issues when linking libisis. Addresses #5346. * The cnetdiff application has been refactored to be callable; Makefile tests have been removed and replaced by gtests. (#5323) * The cnetedit applciation has been refactored to be callable; Makefile tests have been removed and replace by gtests. Addresses #5322. * Moved CHANGELOG.md entry for cnetdiff changes from "Added" section to "Changed" section per reviewer suggestion. Addresses #5322. * Reverted back to original ControlNetDiff source and header files per reviewer suggestion. Addresses #5322. * Changes to cnetdiff.cpp and main.cpp to use the addLogGroup method to add PvlGroups to Pvl. Per reviewer suggestion. Addresses #5322. * Put back line erroneously removed in CHANGELOG.md, per review. Addresses #5322. * Version ticks * Updated changelog * Updated changelog --------- Co-authored-by: kledmundson <[email protected]> Co-authored-by: Christine Kim <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Jacob Cain <[email protected]>
acpaquette
added a commit
to acpaquette/ISIS3
that referenced
this issue
Mar 29, 2024
* Cnetthinner application bug fix resolving divide by zero in CnetManager.cpp. (DOI-USGS#5356) * Bug fix for a divide by zero in CnetManager.cpp. Additionally, the cnetthinner app has been converted to a callable function and Makefile tests converted to gtests. Addresses DOI-USGS#5354. * Updated CHANGELOG.md. Addresses DOI-USGS#5354. * Minor change to cnetthinner.xml. Addresses DOI-USGS#5354. * Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format. Fixes DOI-USGS#3621. (DOI-USGS#5175) * Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format * Updated CHANGELOG * Dawn Target Translation Fix (DOI-USGS#5294) * Fixes dawn target translation for CERES images * Added Changelog entry * CSM Camera Qview Try Catches (DOI-USGS#5295) * Fix errors when using CSM camera in qview * Added Changelog entry * Fixes CSV parsing in shadowtau (DOI-USGS#5316) * Fixes CSV parsing in shadowtau * Addressed PR feedback * Error Report Fix for Program Launcher (DOI-USGS#5331) * Removed line that gets class, it is derived from the code * Added more detailed error around itime not finding the leapsecond kernel * Added changelog entry * Updated trimfilter to correctly use high/low filters (DOI-USGS#5340) * Added high/low filters to trimfilter * Updated changelog * Updated changelog --------- Co-authored-by: acpaquette <[email protected]> * corrected calibration inclusion filter (needed ,) (DOI-USGS#5357) * corrected calibration inclusion filter (needed ,) * changelog entry downloadIsisData fix * Updated changelog * Updated changelog * Cnetthinner application bug fix resolving divide by zero in CnetManager.cpp. (DOI-USGS#5356) * Bug fix for a divide by zero in CnetManager.cpp. Additionally, the cnetthinner app has been converted to a callable function and Makefile tests converted to gtests. Addresses DOI-USGS#5354. * Updated CHANGELOG.md. Addresses DOI-USGS#5354. * Minor change to cnetthinner.xml. Addresses DOI-USGS#5354. * The cnetedit application has been refactored to be callable; Makefile tests have been removed and replaced by gtests (DOI-USGS#5348) * The cnetedit application has been refactored to be callable; Makefile tests have been migrated to gtest format. Addresses DOI-USGS#5346. * Removed extraneous variables from FunctionalTestsCnetedit.cpp. Addresses DOI-USGS#5346. * Updated gtests; replace cubes with labels. Addresses DOI-USGS#5346. * Per review cleaned up sloppy spacing; made global variables static in cnetedit.cpp to avoid issues when linking libisis. Addresses DOI-USGS#5346. * The cnetdiff application has been refactored to be callable; Makefile tests have been removed and replaced by gtests. (DOI-USGS#5323) * The cnetedit applciation has been refactored to be callable; Makefile tests have been removed and replace by gtests. Addresses DOI-USGS#5322. * Moved CHANGELOG.md entry for cnetdiff changes from "Added" section to "Changed" section per reviewer suggestion. Addresses DOI-USGS#5322. * Reverted back to original ControlNetDiff source and header files per reviewer suggestion. Addresses DOI-USGS#5322. * Changes to cnetdiff.cpp and main.cpp to use the addLogGroup method to add PvlGroups to Pvl. Per reviewer suggestion. Addresses DOI-USGS#5322. * Put back line erroneously removed in CHANGELOG.md, per review. Addresses DOI-USGS#5322. * Version ticks * Updated changelog * Updated changelog --------- Co-authored-by: kledmundson <[email protected]> Co-authored-by: Christine Kim <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Jacob Cain <[email protected]>
acpaquette
added a commit
that referenced
this issue
Mar 29, 2024
* Cnetthinner application bug fix resolving divide by zero in CnetManager.cpp. (#5356) * Bug fix for a divide by zero in CnetManager.cpp. Additionally, the cnetthinner app has been converted to a callable function and Makefile tests converted to gtests. Addresses #5354. * Updated CHANGELOG.md. Addresses #5354. * Minor change to cnetthinner.xml. Addresses #5354. * Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format. Fixes #3621. (#5175) * Update photomet's MinnaertEmpirical model to handle PVL input in photemplate format * Updated CHANGELOG * Dawn Target Translation Fix (#5294) * Fixes dawn target translation for CERES images * Added Changelog entry * CSM Camera Qview Try Catches (#5295) * Fix errors when using CSM camera in qview * Added Changelog entry * Fixes CSV parsing in shadowtau (#5316) * Fixes CSV parsing in shadowtau * Addressed PR feedback * Error Report Fix for Program Launcher (#5331) * Removed line that gets class, it is derived from the code * Added more detailed error around itime not finding the leapsecond kernel * Added changelog entry * Updated trimfilter to correctly use high/low filters (#5340) * Added high/low filters to trimfilter * Updated changelog * Updated changelog --------- Co-authored-by: acpaquette <[email protected]> * corrected calibration inclusion filter (needed ,) (#5357) * corrected calibration inclusion filter (needed ,) * changelog entry downloadIsisData fix * Updated changelog * Updated changelog * Cnetthinner application bug fix resolving divide by zero in CnetManager.cpp. (#5356) * Bug fix for a divide by zero in CnetManager.cpp. Additionally, the cnetthinner app has been converted to a callable function and Makefile tests converted to gtests. Addresses #5354. * Updated CHANGELOG.md. Addresses #5354. * Minor change to cnetthinner.xml. Addresses #5354. * The cnetedit application has been refactored to be callable; Makefile tests have been removed and replaced by gtests (#5348) * The cnetedit application has been refactored to be callable; Makefile tests have been migrated to gtest format. Addresses #5346. * Removed extraneous variables from FunctionalTestsCnetedit.cpp. Addresses #5346. * Updated gtests; replace cubes with labels. Addresses #5346. * Per review cleaned up sloppy spacing; made global variables static in cnetedit.cpp to avoid issues when linking libisis. Addresses #5346. * The cnetdiff application has been refactored to be callable; Makefile tests have been removed and replaced by gtests. (#5323) * The cnetedit applciation has been refactored to be callable; Makefile tests have been removed and replace by gtests. Addresses #5322. * Moved CHANGELOG.md entry for cnetdiff changes from "Added" section to "Changed" section per reviewer suggestion. Addresses #5322. * Reverted back to original ControlNetDiff source and header files per reviewer suggestion. Addresses #5322. * Changes to cnetdiff.cpp and main.cpp to use the addLogGroup method to add PvlGroups to Pvl. Per reviewer suggestion. Addresses #5322. * Put back line erroneously removed in CHANGELOG.md, per review. Addresses #5322. * Version ticks * Updated changelog * Updated changelog --------- Co-authored-by: kledmundson <[email protected]> Co-authored-by: Christine Kim <[email protected]> Co-authored-by: acpaquette <[email protected]> Co-authored-by: Jacob Cain <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The cnetdiff application needs to be refactored to be callable. Makefile tests need to be replaced with gtests.
The text was updated successfully, but these errors were encountered: