Noproj bug when running from GUI without specifying a match cube

[kledmundson]

ISIS version(s) affected: Latest

Description

When running noproj from the GUI, if a match cube is not explicitly specified, the program fails with the following error...

How to reproduce

Run noproj from GUI with no match cube.

Possible Solution

This was likely introduced when noproj was converted to a callable function.

In the method void noproj(UserInterface &ui), a cube object is constructed and passed to the programmatic noproj interface, even if it has not been entered in the GUI.

    Cube mcube;
    if((ui.WasEntered("MATCH"))) {
      mcube.open(ui.GetCubeName("MATCH"));
    }

    noproj(&icube, &mcube, ui);

Then, in the programmatic interface, mcube is never NULL so an attempt to open is made, and fails...

    if (mcube != NULL) {
      p.SetInputCube(mcube);
      p.SetInputCube(icube);
    }
    else {
      p.SetInputCube(icube);
      mcube = icube;
    }

This could be fixed by changing mcube to a default parameter in the programmatic interface...

xtern void noproj(Cube *icube,  UserInterface &ui,
                                  Cube *mcube=null);

Additional context

Encountered on Intel MacBook Pro running macOS Monterey 12.7.2.