Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud invites are crazy long #2160

Closed
trevj opened this issue Jan 5, 2016 · 4 comments
Closed

cloud invites are crazy long #2160

trevj opened this issue Jan 5, 2016 · 4 comments
Labels

Comments

@trevj
Copy link
Contributor

trevj commented Jan 5, 2016

Right now, cloud invites include a 2048 bit RSA key:
https://github.com/uProxy/uproxy-docker/blob/master/sshd/issue_invite.sh#L58

Base64-encoded, this causes cloud invites to balloon to >3000 characters!

A 256 bit Ed25519 key would help keep the size of cloud invites to ~500 characters but unfortunately ssh2-streams doesn't support them yet:
mscdex/ssh2-streams#3

@dborkan
Copy link
Contributor

dborkan commented Jan 5, 2016

Semi related, Quiver invites are also too long, and also include 2 public keys plus the whole -----BEGIN PGP PUBLIC KEY BLOCK----- and -----END PGP PUBLIC KEY BLOCK----- pieces. Might be good to come up with a similar solution for Quiver and Cloud

@mollyling
Copy link
Collaborator

I put in a bug for the --BEGIN/END-- padding. For a minimal invite, the way to do this is figure out a binary format for this and then ascii-encode that. Then a utility function to convert from/to JSON would do it. I doubt the keys can be compressed (e.g., gzip) much, but we could do more with our own format. But maybe that's a long-term issue.

Do we need the full key in there, or just an identifier+hash? Then some way to find the full key. But that's probably just a chicken-egg cycle.

@trevj
Copy link
Contributor Author

trevj commented Jan 15, 2016

Just noticed this also messes up the www.uproxy.org/invite handler. It gives a 400. That's a blocker for anyone following the upcoming blog post...so raising this to P1.

Perhaps for now we should consider shortening the keys just enough to get us under the 2K URL limit.

@trevj trevj added P1 and removed P2 labels Jan 15, 2016
@trevj trevj added P2 and removed P1 labels Jan 22, 2016
@trevj
Copy link
Contributor Author

trevj commented Jan 22, 2016

Hmm. Right now, Chrome is handling the longer URLs (>3k) just fine. So I don't think this is a blocker after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants