Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GtkPopovers instead of menuitems #5

Open
fossfreedom opened this issue Feb 6, 2017 · 1 comment
Open

GtkPopovers instead of menuitems #5

fossfreedom opened this issue Feb 6, 2017 · 1 comment

Comments

@fossfreedom
Copy link
Member

fossfreedom commented Feb 6, 2017

Suggestion from @ikeydoherty via IRC: "for using a popover im kinda wondering if you could get away with using a gmenumodel or even a gtklistbox"

Need to investigate

EDIT: gtkmenubutton you can add the indicatorobject gtkmenu - so maybe a gtklistbox with one row of gtkmenubuttons ?

EDIT: nope - adding a Gtk.Menu using set_popover just creates a non popover style menu.

Problem is that appindicators are basically Gtk.MenuItems so somehow need to convert Gtk.MenuItems to Gio.MenuModel

Elementary achieved this like this http://bazaar.launchpad.net/~elementary-pantheon/wingpanel-indicator-ayatana/master/view/head:/src/AyatanaIndicator.vala

@HEXcube HEXcube changed the title gtkpopovers instead of menuitems GtkPopovers instead of menuitems Mar 26, 2017
@HEXcube
Copy link

HEXcube commented Mar 26, 2017

I don't know much about the internal mechanics of different Popover implementations, but they sure look better than the old menuitems. Not sure if it's really relevant, but see these two extensions for Gnome Shell:

Popover vs Menuitems

Image's from an OMG!Ubuntu article featuring an extension for turning AppIndicators into Gnome Shell styled Popovers - See Link to article

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants