Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard-coded page limit in GetChapterUrls is too small #2

Open
jakoschiko opened this issue Jan 4, 2021 · 3 comments
Open

Hard-coded page limit in GetChapterUrls is too small #2

jakoschiko opened this issue Jan 4, 2021 · 3 comments

Comments

@jakoschiko
Copy link
Contributor

GetChapterUrls has a hard-coded limit for pages.

if (prevPage != "" && prevPage == page) || i > 8 {
	break
}

In my case it was not enough. IMHO the current limit is too small and should be raised (or removed).

@UnicodingUnicorn
Copy link
Owner

I remember the limit was there for a reason, but I can't remember what it was. Have you tried removing it and seeing what breaks?

@jakoschiko
Copy link
Contributor Author

I removed the limit and everything worked fine. Maybe it's some kind of timeout in case the user uses an invalid URL?

@UnicodingUnicorn
Copy link
Owner

Huh that's interesting. I really want to know what past-me was thinking. Alright, I'll remove the limit in a commit soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants