Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nc_inq_base_pe()/nc_set_base_pe() from dispatch table? #1467

Closed
edhartnett opened this issue Aug 15, 2019 · 1 comment · Fixed by #1468
Closed

Remove nc_inq_base_pe()/nc_set_base_pe() from dispatch table? #1467

edhartnett opened this issue Aug 15, 2019 · 1 comment · Fixed by #1468

Comments

@edhartnett
Copy link
Contributor

This is related to #1056

We have nc_inq_base_pe() and nc_set_base_pe(). These are obsolete functions that do nothing. The only valid value for pe is zero, and it is ignored. (See #1459 for more info on these ancient Cray functions, which no longer work, on Crays or any other systems.)

Can we remove these two functions from the dispatch table?

Seems like we can, and still support them, by sill supporting the functions (although they do nothing) in libsrc, and simply removing them from all dispatch tables.

The advantage is that we will reduce the number of functions that each dispatch layer must support, and remove the do-nothing version of these functions in libdispatch/ncnotnc3.c.

@DennisHeimbigner do you see any difficulty or problem with this?

@edhartnett
Copy link
Contributor Author

OK, I just gave this a whack and it works well and was easy. PR up shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant