Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake: Find HDF5 header we can safely include for other checks #2762

Merged
merged 2 commits into from
Jan 18, 2024

Conversation

ZedThree
Copy link
Contributor

@ZedThree ZedThree commented Oct 6, 2023

I was a bit hasty in #2757: some linux distros rename H5pubconf.h so we need to potentially check a few headers. I've wrapped this up to keep things clean in the main CMake file.

@WardF
Copy link
Member

WardF commented Oct 6, 2023

Interesting, thanks. Out of curiosity, what is one of the Linux distros which does this? I'd be curious to run some tests.

@ZedThree
Copy link
Contributor Author

ZedThree commented Oct 6, 2023

"Enterprise Linux" (RedHat, Fedora, etc). I checked pkgs.org for others. I encountered this trying to build netCDF inside the manylinux_2_28 container for Python

@ZedThree
Copy link
Contributor Author

Further reference, this is what the built-in FindHDF5.cmake module does too:

      foreach(_hdr "${_dir}/H5pubconf.h" "${_dir}/H5pubconf-64.h" "${_dir}/H5pubconf-32.h")

So could even drop H5public.h here?

@ZedThree ZedThree force-pushed the cmake-better-fix-hdf5-check branch from adb84d5 to e6f68f7 Compare January 18, 2024 16:05
@ZedThree
Copy link
Contributor Author

Updated now #2838 is in

@WardF WardF merged commit 359a015 into Unidata:main Jan 18, 2024
53 of 64 checks passed
@WardF
Copy link
Member

WardF commented Jan 18, 2024

Thanks!

@ZedThree ZedThree deleted the cmake-better-fix-hdf5-check branch January 19, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants