From 12627020d70769e92ff11e00afd7c8d5c3333442 Mon Sep 17 00:00:00 2001
From: nicholas-goodwin <111888703+nicholas-goodwin@users.noreply.github.com>
Date: Wed, 12 Apr 2023 14:15:33 -0500
Subject: [PATCH] 1018 data dictionary refactor (#1654)

* data dictionary restructure

* version bump and formatting

* fixed csv

* fixed misc bugs

* version bump and format

* removed commented code

* removed commented code and some cleaning

* more formatting

* fixing csv, tsv, and overwrite

* version bump and format
---
 .../data_dictionary/data_dictionary_form.ex   | 37 ++++++++++++++-----
 apps/andi/mix.exs                             |  2 +-
 2 files changed, 28 insertions(+), 11 deletions(-)

diff --git a/apps/andi/lib/andi_web/live/ingestion_live_view/data_dictionary/data_dictionary_form.ex b/apps/andi/lib/andi_web/live/ingestion_live_view/data_dictionary/data_dictionary_form.ex
index f9812a047..2a249332f 100644
--- a/apps/andi/lib/andi_web/live/ingestion_live_view/data_dictionary/data_dictionary_form.ex
+++ b/apps/andi/lib/andi_web/live/ingestion_live_view/data_dictionary/data_dictionary_form.ex
@@ -345,7 +345,13 @@ defmodule AndiWeb.IngestionLiveView.DataDictionaryForm do
             {:ok, assign(socket, loading_schema: false, current_data_dictionary_item: :no_dictionary)}
 
           false ->
-            {:ok, assign(socket, loading_schema: false, pending_schema: decoded_json, overwrite_schema_visible?: true)}
+            {:ok,
+             assign(socket,
+               loading_schema: false,
+               pending_schema: decoded_json,
+               pending_file_type: "application/json",
+               overwrite_schema_visible?: true
+             )}
         end
     end
   end
@@ -357,7 +363,7 @@ defmodule AndiWeb.IngestionLiveView.DataDictionaryForm do
         {:ok, assign(socket, schema_sample_errors: "There was a problem interpreting this file")}
 
       {:ok, csv_file} ->
-        decoded_csv = parse_sv_file(csv_file, file_type)
+        decoded_file = parse_sv_file(csv_file, file_type)
 
         is_schema_empty? =
           case Changeset.fetch_field(socket.assigns.changeset, :schema) do
@@ -369,7 +375,7 @@ defmodule AndiWeb.IngestionLiveView.DataDictionaryForm do
         case is_schema_empty? do
           true ->
             changeset =
-              decoded_csv
+              decoded_file
               |> List.wrap()
               |> DataDictionaryFormSchema.changeset_from_tuple_list(socket.assigns.ingestion_id)
 
@@ -378,7 +384,13 @@ defmodule AndiWeb.IngestionLiveView.DataDictionaryForm do
             {:ok, assign(socket, loading_schema: false, current_data_dictionary_item: :no_dictionary)}
 
           false ->
-            {:ok, assign(socket, loading_schema: false, pending_schema: decoded_csv, overwrite_schema_visible?: true)}
+            {:ok,
+             assign(socket,
+               loading_schema: false,
+               pending_schema: decoded_file,
+               pending_file_type: file_type,
+               overwrite_schema_visible?: true
+             )}
         end
     end
   end
@@ -392,10 +404,15 @@ defmodule AndiWeb.IngestionLiveView.DataDictionaryForm do
   end
 
   def update(%{action: :overwrite_schema}, socket) do
-    schema_changesets =
+    schema_list =
       socket.assigns.pending_schema
       |> List.wrap()
-      |> DataDictionaryFormSchema.changeset_from_file(socket.assigns.ingestion_id)
+
+    schema_changesets =
+      case socket.assigns.pending_file_type do
+        "application/json" -> DataDictionaryFormSchema.changeset_from_file(schema_list, socket.assigns.ingestion_id)
+        _ -> DataDictionaryFormSchema.changeset_from_tuple_list(schema_list, socket.assigns.ingestion_id)
+      end
 
     send(self(), {:update_data_dictionary, schema_changesets})
 
@@ -553,17 +570,17 @@ defmodule AndiWeb.IngestionLiveView.DataDictionaryForm do
   end
 
   defp parse_sv_file(file_string, file_type) do
-    regex =
+    {regex, split_text} =
       case file_type do
-        "text/csv" -> ~r/[^[:alnum:] _,]/
-        "text/plain" -> ~r/[^[:alnum:] _\t]/
+        "text/csv" -> {~r/[^[:alnum:] _,]/, ","}
+        _ -> {~r/[^[:alnum:] _\t]/, "\t"}
       end
 
     file_string
     |> String.split("\n")
     |> Enum.take(2)
     |> List.update_at(0, &String.replace(&1, regex, "", global: true))
-    |> Enum.map(fn row -> String.split(row, "\t") end)
+    |> Enum.map(fn row -> String.split(row, split_text) end)
     |> Enum.zip()
     |> Enum.map(fn {k, v} -> {k, convert_value(v)} end)
   end
diff --git a/apps/andi/mix.exs b/apps/andi/mix.exs
index 6cfe5110f..8208bd0e0 100644
--- a/apps/andi/mix.exs
+++ b/apps/andi/mix.exs
@@ -4,7 +4,7 @@ defmodule Andi.MixProject do
   def project do
     [
       app: :andi,
-      version: "2.6.56",
+      version: "2.6.57",
       build_path: "../../_build",
       config_path: "../../config/config.exs",
       deps_path: "../../deps",