get-schema doesn't update the generated schema when called in post-deploy hook of prisma.yml #354

carstenbaumhoegger · 2018-11-08T13:39:24Z

Describe the bug
As I updated to [email protected] today I noticed a strange behaviour of graphql get-schema.
I haven't touched my prisma.yml for months but suddenly today after some changes in datamodel.graphql, the generated files remained unchanged after running graphql get-schema in prisma.yml post-deploy.

When I run graphql get-schema from my command line it notices the changes and generates the new schema files as expected.

To Reproduce
Steps to reproduce the behavior:

Change something in datamodel.graphql
re-deploy prisma
See, that the schema files in src/generated remain untouched

Expected behavior
The schema files get updated accordingly to the changes in the datamodel.

Versions (please complete the following information):

OS: macOS Mojave
graphql-cli: 2.17.0
prisma: 1.20.0
node: 10.10.0

The text was updated successfully, but these errors were encountered:

Siyfion · 2018-11-13T14:25:50Z

I am also suffering from this issue!

nikolasburk · 2018-11-13T14:47:18Z

As a workaround, you can generate prisma.graphql using the prisma generate command:

Add the following code to your prisma.yml:

generate:
   - generator: graphql-schema
     output: ./generated/

Run prisma generate (The prisma.graphql will now be generated in the ./generated folder. It's currently not possible to specify a different name for that file, see this GitHub issue).
To automatically update prisma.graphql after prisma deploy is ran, you need to configure a post-deploy hook in prisma.yml:
```
hooks:
  post-deploy:
    - prisma generate
```

maticzav · 2018-11-16T22:46:08Z

@carstenbaumhoegger could you verify that this is not the same issue as prisma/prisma#3491? This would help a lot with navigation of the problem. 🙂

baninaveen · 2018-11-19T01:59:29Z

I encounter same issue

carstenbaumhoegger · 2018-11-28T11:16:51Z

@nikolasburk thanks for posting the workaround!
Unfortunately when I modify my prisma.yml and run this, I get Relation type mismatch. as error.

@maticzav I'm working on macOS and can't reproduce this issue

pixelbacon · 2018-12-04T06:24:52Z

@maticzav OSX, same issue

OS: macOS Mojave
node:10.9.0
yarn:1.12.3
prisma:^1.21.1
graphql-cli:^2.17.0

Running graphql get-schema --project db generates proper src/generated/prisma.graphql.
Running prisma deploy says both steps completed w/ success but the src/generated/prisma.graphql does appear.

.graphqlconfig.yml

projects:
  app:
    schemaPath: src/schema.graphql
    extensions:
      endpoints:
        default: http://localhost:4000
  db:
    schemaPath: src/generated/prisma.graphql
    extensions:
      prisma: database/prisma.yml
      prepare-binding:
        output: src/generated/prisma.ts
        generator: prisma-ts

database/prisma.yml

secret: ${env:PRISMA_SECRET}
endpoint: ${env:PRISMA_ENDPOINT}
datamodel:
  - types.graphql
  - enums.graphql
hooks:
  post-deploy:
    - graphql get-schema --project db
    - graphql prepare

package.json

{
  "name": "demo-app",
  "scripts": {
    "start": "dotenv -- nodemon -e ts,graphql -x ts-node src/index.ts",
    "dev": "npm-run-all --parallel start playground",
    "debug": "dotenv -- nodemon -e ts,graphql -x ts-node --inspect src/index.ts",
    "playground": "graphql playground",
    "build": "rimraf dist && tsc",
    "prisma": "dotenv -- prisma",
    "db:seed": "dotenv -- ts-node src/seed.ts",
    "db:up": "docker-compose up -d",
    "db:down": "docker-compose down",
    "db:stop": "docker-compose stop"
  },
  "dependencies": {
    "@types/cors": "^2.8.4",
    "@types/jsonwebtoken": "^8.3.0",
    "@types/lodash": "^4.14.118",
    "@types/moment": "^2.13.0",
    "@types/node": "^10.12.11",
    "apollo-cache-inmemory": "^1.3.11",
    "apollo-cache-persist": "^0.1.1",
    "bcryptjs": "^2.4.3",
    "cors": "^2.8.5",
    "debug": "^4.1.0",
    "dotenv-cli": "^1.4.0",
    "express-jwt": "^5.3.1",
    "graphql-middleware-forward-binding": "^1.3.2",
    "graphql-shield": "^4.1.0",
    "graphql-yoga": "^1.16.7",
    "jsonwebtoken": "^8.3.0",
    "jwks-rsa": "^1.3.0",
    "moment": "^2.22.2",
    "nodemon": "^1.18.6",
    "prisma-binding": "^2.2.8",
    "ts-lint": "^4.5.1",
    "ts-node": "^7.0.1",
    "typescript": "^3.1.6"
  },
  "devDependencies": {
    "@types/graphql": "^14.0.3",
    "graphql-cli": "^2.17.0",
    "npm-run-all": "^4.1.5",
    "prisma": "^1.21.1"
  }
}

pixelbacon · 2018-12-04T06:49:52Z

Further reading...

npm ls | grep graphql-cli

├─┬ [email protected]
│ ├─┬ [email protected]
npm ERR! peer dep missing: graphql@^0.13.1, required by [email protected]
npm ERR! peer dep missing: graphql@^0.13.2, required by [email protected]
npm ERR! peer dep missing: graphql@^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0, required by [email protected]
npm ERR! extraneous: [email protected] /xxx/node_modules/node-pre-gyp
npm ERR! extraneous: [email protected] /xxx/dev/veed-backend/node_modules/apollo-codegen/node_modules/graphql-config/node_modules/graphql-import/node_modules/graphql
npm ERR! peer dep missing: graphql@^0.11.0 || ^0.12.0 || ^0.13.0, required by [email protected]
npm ERR! extraneous: [email protected] /xxx/dev/veed-backend/node_modules/graphql-static-binding/node_modules/graphql
npm ERR! extraneous: [email protected] /xxx/dev/veed-backend/node_modules/graphql-config/node_modules/graphql
npm ERR! peer dep missing: graphql@^0.12.0 || ^0.13.0, required by @kbrandwijk/[email protected]
npm ERR! extraneous: [email protected] /xxx/dev/veed-backend/node_modules/@kbrandwijk/swagger-to-graphql/node_modules/graphql
npm ERR! peer dep missing: graphql@^0.13.1, required by [email protected]
npm ERR! peer dep missing: graphql@^0.13.2, required by [email protected]
npm ERR! peer dep missing: graphql@^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0, required by [email protected]
npm ERR! peer dep missing: graphql@^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0, required by [email protected]
npm ERR! peer dep missing: [email protected] - 0.13.x, required by [email protected]
npm ERR! peer dep missing: [email protected] - 0.13.x, required by [email protected]
npm ERR! peer dep missing: [email protected] - 0.13.x, required by [email protected]
npm ERR! peer dep missing: [email protected] - 0.13.x, required by [email protected]
npm ERR! peer dep missing: [email protected] - 0.13.x, required by [email protected]
npm ERR! peer dep missing: graphql@^0.9.0 || ^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0, required by [email protected]
npm ERR! peer dep missing: graphql@^0.13.1, required by [email protected]
npm ERR! peer dep missing: graphql@^0.13.2, required by [email protected]
npm ERR! peer dep missing: graphql@^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0, required by [email protected]
npm ERR! peer dep missing: graphql@^0.13.1, required by [email protected]
npm ERR! peer dep missing: graphql@^0.13.2, required by [email protected]
npm ERR! peer dep missing: graphql@^0.10.5 || ^0.11.3 || ^0.12.0 || ^0.13.0, required by [email protected]

pixelbacon · 2018-12-04T07:02:22Z

@maticzav @carstenbaumhoegger
Working. May have been an upgrade issue.

package.json as seen at graphql-boilerplates/node-graphql-server#211

{
  ...
  "resolutions": {
    "graphql": "^0.13.0",
    "**/graphql": "^0.13.0"
  }
}

prisma.yml

secret: ${env:PRISMA_SECRET}
endpoint: ${env:PRISMA_ENDPOINT}
datamodel:
  - types.graphql
  - enums.graphql
hooks:
  post-deploy:
    - graphql get-schema --project db
    - graphql codegen

.graphqlconfig.yml

projects:
  app:
    schemaPath: src/schema.graphql
    extensions:
      endpoints:
        default: http://localhost:4000
  db:
    schemaPath: src/generated/prisma.graphql
    extensions:
      prisma: database/prisma.yml
      codegen:
        - generator: prisma-binding
          language: typescript
          output:
            binding: src/generated/prisma.ts

Urigo · 2019-10-29T18:17:02Z

We've just released a new alpha version channel for GraphQL CLI - 4.0.0-alpha.XXX!

We've changed the get-schema command to use GraphQL Code Generator plugin of GraphQL CLI with the Codegen's schema-ast plugin.

Could you please test it out with your Prisma setup and let us know if the new structure solves your issue?

Checkout new instructions in the migration guide and let us know your feedback during that alpha period!

Feel free to contact us by opening a new issue or joining our Discord channel;
https://discord.gg/xud7bH

Urigo · 2019-10-29T19:52:12Z

I've posted the wrong Discord link, this is the correct one: https://discord.gg/xud7bH9

carstenbaumhoegger changed the title ~~get-schema doesn't update the generated schema when called in post-deploy hook of prisma.yml~~ get-schema doesn't update the generated schema when called in post-deploy hook of prisma.yml Nov 8, 2018

maticzav self-assigned this Nov 14, 2018

ardatan closed this as completed Oct 28, 2019

Repository owner deleted a comment from ardatan Oct 29, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

get-schema doesn't update the generated schema when called in post-deploy hook of prisma.yml #354

get-schema doesn't update the generated schema when called in post-deploy hook of prisma.yml #354

carstenbaumhoegger commented Nov 8, 2018

Siyfion commented Nov 13, 2018

nikolasburk commented Nov 13, 2018 •

edited

Loading

maticzav commented Nov 16, 2018

baninaveen commented Nov 19, 2018

carstenbaumhoegger commented Nov 28, 2018 •

edited

Loading

pixelbacon commented Dec 4, 2018 •

edited

Loading

pixelbacon commented Dec 4, 2018 •

edited

Loading

pixelbacon commented Dec 4, 2018 •

edited

Loading

Urigo commented Oct 29, 2019

Urigo commented Oct 29, 2019

get-schema doesn't update the generated schema when called in post-deploy hook of prisma.yml #354

get-schema doesn't update the generated schema when called in post-deploy hook of prisma.yml #354

Comments

carstenbaumhoegger commented Nov 8, 2018

Siyfion commented Nov 13, 2018

nikolasburk commented Nov 13, 2018 • edited Loading

maticzav commented Nov 16, 2018

baninaveen commented Nov 19, 2018

carstenbaumhoegger commented Nov 28, 2018 • edited Loading

pixelbacon commented Dec 4, 2018 • edited Loading

pixelbacon commented Dec 4, 2018 • edited Loading

pixelbacon commented Dec 4, 2018 • edited Loading

Urigo commented Oct 29, 2019

Urigo commented Oct 29, 2019

nikolasburk commented Nov 13, 2018 •

edited

Loading

carstenbaumhoegger commented Nov 28, 2018 •

edited

Loading

pixelbacon commented Dec 4, 2018 •

edited

Loading

pixelbacon commented Dec 4, 2018 •

edited

Loading

pixelbacon commented Dec 4, 2018 •

edited

Loading