Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broad significance distributions #43

Open
samanthalwong opened this issue May 22, 2024 · 2 comments
Open

Broad significance distributions #43

samanthalwong opened this issue May 22, 2024 · 2 comments
Labels
help wanted Extra attention is needed validation Issues holding up validation

Comments

@samanthalwong
Copy link
Collaborator

samanthalwong commented May 22, 2024

There was previously a bug where the we were correcting for the pileup at zero in significance distributions by plotting the OFF distribution as significance_off[exclusion_mask.data.flatten()]. When a gaussian distribution is fit to this distribution, it is broad (sigma ~ 1.15) and skewed negative (mu ~ -0.1) for several bright point source fields that show nice distributions in ED (Crab, Mrks).

It looks like some of the ON region is leaking into the background a bit.

This might be related to the energy range supplied to the ExcessMapEstimator (I get marginally better results by restricting the range of energies that are accepted), but I'm not sure.

I get identical results with and without bkg smoothing as well, so unrelated to that.

@samanthalwong samanthalwong added the help wanted Extra attention is needed label May 22, 2024
@samanthalwong
Copy link
Collaborator Author

e.g., for the 4 crab test runs:
image

@samanthalwong
Copy link
Collaborator Author

This seems to be entirely related to the bkg generation - running the same pipeline with H.E.S.S. data gives perfect distributions.

So probably unrelated to ON region size, energy ranges, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed validation Issues holding up validation
Projects
None yet
Development

No branches or pull requests

1 participant