Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to find_exclusion #56

Open
samanthalwong opened this issue Aug 6, 2024 · 3 comments
Open

Improvements to find_exclusion #56

samanthalwong opened this issue Aug 6, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@samanthalwong
Copy link
Collaborator

samanthalwong commented Aug 6, 2024

For runwise bkg generation: exclusion region should come from config['sky_map]['on_exclusion_region'] to avoid leakage of bright sources as ring artifacts into their acceptances

For normal bkg generation: exclude runs with known bright sources (Crab, Mrks, etc.) from being included at all - Tobias has something similar in his scripts in DL3-Analysis

@samanthalwong samanthalwong added the enhancement New feature or request label Aug 6, 2024
Copy link
Collaborator

steob92 commented Aug 6, 2024

I’d be more inclined to correctly implement the custom exclusion region than add an additional parameter. At the moment there is an option to exclude runs taken on a predefined list of sources.

Additionally we get the exclusion for extended sources based on their morphology with an option to override the default exclusion.

@samanthalwong
Copy link
Collaborator Author

Ok sorry I think these are just misunderstandings on my part as to how to use the exclusion regions so I will close this issue and fix my implementation instead

@steob92 steob92 reopened this Aug 12, 2024
@steob92
Copy link
Collaborator

steob92 commented Aug 12, 2024

@samanthalwong Can you check out:
https://github.com/VERITAS-Observatory/gammapy-tools/tree/on_exclusion

It should pick up on the default on_region specified in the "sky_map" section. Can you test this? If its all good with you I'll change this so that the parameter is in "background" selection and then defaults to "sky_map" if it isn't specified by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants