Tab and Escape do not work with Next Edit Suggestions

[lcmen]

Describe the bug

When new Next Edit Suggestions (currently in Preview) is enabled. Tab and Escape to Accept / Reject Next Edit Suggestion does not do anything.

To Reproduce
Steps to reproduce the behavior:

1. Enable github.copilot.nextEditSuggestions.enabled
2. Change a code so Next Edit Suggestions icon appears
3. Try to hit Tab or Escape

Expected behavior

Tab accepts next edit suggestion, Escape reject next edit suggestion.

• Extension (VsCodeVim) version: 1.29.0
• VSCode version: Version: 1.97.2
• OS: MacOS Sonoma

[tramsi]

@lcmen I found a temporary solution just to increase the precedence of the copilot next edit suggestions keybindings
just add the following to your user keybindings.json
[ { "key": "tab", "command": "editor.action.inlineSuggest.commit", "when": "inlineEditIsVisible && tabShouldAcceptInlineEdit && !editorHoverFocused && !editorTabMovesFocus && !suggestWidgetVisible || inlineSuggestionHasIndentationLessThanTabSize && inlineSuggestionVisible && !editorHoverFocused && !editorTabMovesFocus && !suggestWidgetVisible || inlineEditIsVisible && inlineSuggestionHasIndentationLessThanTabSize && inlineSuggestionVisible && !editorHoverFocused && !editorTabMovesFocus && !suggestWidgetVisible || inlineEditIsVisible && inlineSuggestionVisible && tabShouldAcceptInlineEdit && !editorHoverFocused && !editorTabMovesFocus && !suggestWidgetVisible" }, { "key": "tab", "command": "editor.action.inlineSuggest.commit", "when": "inInlineEditsPreviewEditor" }, { "key": "tab", "command": "editor.action.inlineSuggest.jump", "when": "inlineEditIsVisible && tabShouldJumpToInlineEdit && !editorHoverFocused && !editorTabMovesFocus && !suggestWidgetVisible" }, { "key": "escape", "command": "editor.action.inlineSuggest.hide", "when": "inInlineEditsPreviewEditor" }, { "key": "escape", "command": "editor.action.inlineSuggest.hide", "when": "inlineEditIsVisible || inlineSuggestionVisible" } ]

BTW these are the default key bindings for this commands, but I found if I added them to the keybindings.json file they would override vim's extensions commands conflicted with them

[baldwin-law]

You can set an alternative key binding in keybinding.json : { "key": "cmd+escape", "command": "editor.action.inlineSuggest.hide", }, { "key": "tab", "command": "-extension.vim_tab", }

[lcmen]

@tramsi but I don't even know what all these conditions are for 😄 . I will try @baldwin-law approach for now as it's much easier to understand. Thank you guys for workarounds!

[tramsi]

It is just copying the default commands from vscode shortcut bindings and pasting them in the user bindings, that will ensure they will override vim's bindings

this is the user bindings I pasted to you, but formatted:

Anyway feel free to use whatever would work with you, I initially handled it like baldwin-law, but my muscle memory prefers only "esc" for the action :D