Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide failure notifications on gated BinaryDataNotifications #1115

Closed
gaasedelen opened this issue Aug 10, 2018 · 1 comment
Closed

Provide failure notifications on gated BinaryDataNotifications #1115

gaasedelen opened this issue Aug 10, 2018 · 1 comment
Labels
State: Duplicate Issue is a duplicate of another issue

Comments

@gaasedelen
Copy link
Contributor

One of the issues IDA struggles with (in regard to events) is that some of their 'gated' event notifications may fail without notification. BN also seems to suffer from this.

By 'gated' events mean an event callback that happens before a certain piece of information is modified in the database, and an event callback that happens after it is modified.

For example, in BinaryDataNotifications we have:

BEFORE - function_update_requested
AFTER  - function_updated

As a plugin developer, I may want to hook function_update_requested to capture some information prior to this object being modified. My hooks then may change their logic to wait for a function_updated event to come through.

But in failure cases, the function_updated event may never get fired off. As a result, my logic is now stuck in a state waiting for an event that may never come (or recieve a completely different one later).

If these gated events cannot complete, you should send out a notification as such:

FAILURE - function_update_canceled

In slack, rss noted that `this might be worth a ticket, my recollection of that path makes that seem like it wouldn't be hard to add'. Filing this so it doesn't get lost.

@plafosse plafosse added the State: Duplicate Issue is a duplicate of another issue label Feb 6, 2019
@plafosse
Copy link
Member

plafosse commented Feb 6, 2019

We believe this would be best implemented as an analysis pass, #471 which we plan but is not done yet. I'm going to close as a dupe.

@plafosse plafosse closed this as completed Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Duplicate Issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

2 participants