Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function un-inlining #2185

Open
nshp opened this issue Dec 8, 2020 · 1 comment
Open

Function un-inlining #2185

nshp opened this issue Dec 8, 2020 · 1 comment
Labels
Component: Core Issue needs changes to the core Effort: High Issue should take > 1 month Impact: High Issue adds or blocks important functionality Type: Enhancement Issue is a small enhancement to existing functionality

Comments

@nshp
Copy link
Contributor

nshp commented Dec 8, 2020

This is a far-off dream of a feature request, but it would be very nice if I could select a chunk of HLIL, mark a few expressions as 'variable', and call it an inlined function or macro. Then binja could search for the IL pattern and mark matches, giving an option to simplify/un-inline the inline function call. The first part could be done as a plugin right now, but the un-inlining part would take some core support (or maybe #1606). I can imagine this playing really well with DWARF or PDB imports, where you have the ground truth for macro expansion/inlining, but also for reversing stripped, optimized code.

@plafosse plafosse added the Type: Enhancement Issue is a small enhancement to existing functionality label Dec 9, 2020
@plafosse
Copy link
Member

plafosse commented Dec 9, 2020

I agree this is an awesome feature that we've talked about for awhile. It could probably be done with a hack with analysis passes when they exist, but the real solution will take considerably more effort. UI wise you'd want some way to view these un-inlined functions much like how you'd normally view functions. For the sake of data flow and type propagation you'd like to still treat them as inlined.

@plafosse plafosse added Effort: High Issue should take > 1 month Impact: High Issue adds or blocks important functionality labels Dec 9, 2020
@plafosse plafosse added the Component: Core Issue needs changes to the core label Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Core Issue needs changes to the core Effort: High Issue should take > 1 month Impact: High Issue adds or blocks important functionality Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants