-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for choosing the conversion counting method of each conversion event #204
Comments
I'm not sure I agree that the current implementation uses the 'once per session' methodology. As you can see in stg_ga4__session_conversions_daily, we simply run a
So the current implementation is "once per event". If someone wanted to implement "once per session" it would be as simple as adding a new column calculated as |
@adamribaudo-velir I said the same thing: "Currently, this package only supports the new way that counts multiple conversions in a session." |
Sorry, I was thinking the 'new way' is once-per-session because Google just released that feature as part of GA4 :) Given that Google provides this feature as an on/off configuration in the property, I would suggest we do something similar rather than count using both methods and potentially confusing users. What I would propose is:
So the column names would remain the same, but the calculation method would change depending on the new variable. |
@adamribaudo-velir It's an on/off setting for each event! |
oh wow. well that complicates things. I'm ok with your option 1 but I'd like to support this in a way that doesn't require updates for existing users of the package. Perhaps we can keep the I don't LOVE it, but it should make things smoother for users without causing too much confusion. |
@adamribaudo-velir Makes sense to not break things for existing users. Just updated the description. |
GA4 allows for either counting multiple conversions in a session, or maxing out at one conversion per session (the traditional UA way). This can be configured separately for each conversion. Details here: https://support.google.com/analytics/answer/13366706?hl=en&utm_id=ad .
Currently, this package only supports the new way that counts multiple conversions in a session. There's two ways this could be supported:
per_event_conversion_events:['purchase'] (EDIT: this should just be 'conversion_events' so that people on previous versions don't have to update)
per_session_conversion_events:['download']
Any thoughts on a preferred approach? I could attempt to implement.
The text was updated successfully, but these errors were encountered: