Update Lints

[lishaduck]

Hi, it's me again!

Is your feature request related to a problem? Please describe.
Update lints for Dart 3.5 (part of #108)

Describe the solution you'd like
Add:

• unintended_html_in_doc_comment (wait a release to check for false positives per unintended_html_in_doc_comment - add to recommended set dart-lang/lints#192 (comment)?),
• invalid_runtime_check_with_js_interop_types (lints is waiting for the next major, but the Dart team agrees that this is stable Consider adding invalid_runtime_check_with_js_interop_types to the recommended rule set dart-lang/lints#188),
• unnecessary_library_name (Now recommended: Consider adding unnecessary_library_name to recommended dart-lang/lints#181),
• document_ignores (Not experimental, I've found it useful in other ecosystems),
• avoid_catches_without_on_clauses (Noted false positives have been fixed),
• type_literal_in_constant_pattern (Now recommended: add several rules to core and recommended dart-lang/lints#150).

Also, remove

• unnecessary_await_in_return (It's be mentioned a few times as likely to be deprecated in favor of Disallow returning futures from async functions. dart-lang/language#870),
• avoid_null_checks_in_equality_operators (Remove avoid_null_checks_in_equality_operators from recommended dart-lang/lints#200),
• library_names (remove the 'library_names' lint dart-lang/lints#183)
• package_prefixed_library_names (Remove package_prefixed_library_names from core set (and deprecate) dart-lang/lints#172), and
• prefer_void_to_null (remove prefer_void_to_null from recommended dart-lang/lints#154; I've run into these false-positives).

Describe alternatives you've considered
Again, put them in manually.

Additional context
I'll PR this, if desired. Not really context, but 🤷‍♂️

[lishaduck]

Oh, and the reason for prefer_final_parameters is that it's incompatible with avoid_final_parameters.

[alestiago]

Hi @lishaduck thanks for suggesting these new additions. I haven't had a time to have a deep dive into the false positives and read through the issues. The team will probably jump into these soon.

If you would like to contribute we're open for Pull Requests. From the ones you listed unnecessary_library_name seems like a reasonable addition since it is now recommend, are you interested in drafting a PR for it? It will be nice if we also update the recommendation table with it (see the linter rules tool).

---

Oh, and the reason for prefer_final_parameters is that it's incompatible with avoid_final_parameters.

Thanks for pointing this out! Feel free to open a Pull Request updating the reason and the team can jump into reviewing it to get it merged 🙌

[lishaduck]

Oh, and type_literal_in_constant_pattern is in recommended now.

---

I'm looking through the lints repo to find as many exclusion reasons as possible, so I've also updated the list of lints to remove.

[wolfenrain]

Opened #121, #122 and #123 to add the mentioned lint rules. I would like to add document_ignores as well but I'll need t o check in with our devs at VGV to see if they see the added value as well.

Also opened #124 to remove avoid_null_checks_in_equality_operators

[tomarra]

Just reviewed this with the team. We have all the suggestions implemented except for unnecessary_await_in_return which we want to hold on for now as the Dart team has not deprecated it yet. Were going to open up a new ticket to track that for the future and will tag this ticket in the process.