Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing use statement should be avoided in BlogController.php : is this valid #60

Closed
lenybernard opened this issue Apr 8, 2015 · 3 comments
Assignees

Comments

@lenybernard
Copy link
Contributor

First observation :

in Bundle/BlogBundle/Controller/BlogController.php, line 179

The BusinessEntityPagePattern class resolves to the following class: Victoire\Bundle\BusinessEntityPageBundle\Entity\BusinessEntityPagePattern.
Did you forget to add a corresponding use statement?

        $entityManager = $this->getDoctrine()->getManager();
        $form = $this->createForm($this->getPageCategoryType(), $blog);
        $businessProperties = array();

        //if the page is a business entity page
        if ($blog instanceof BusinessEntityPagePattern) {
            //we can use the business entity properties on the seo
            $businessEntity = $this->get('victoire_core.helper.business_entity_helper')->findById($blog->getBusinessEntityName());
            $businessProperties = $businessEntity->getBusinessPropertiesByType('seoable');
        }

Second observation:

is this usefull ? this not make sense for me and i wonder why you did this, can you explane me ?

@lenybernard
Copy link
Contributor Author

@Charlie-Lucas I will remove this check unless you tell me why you did this.

@Charlie-Lucas
Copy link
Contributor

@lenybernard this come from the parent controller.

@lenybernard
Copy link
Contributor Author

and... what do you plan to do ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants