-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(lib): bump dependencies, adjust dev and build config, refactor tests, refactor components, adjust docs, a.o. #55
Conversation
… config. update tests. bump all dependencies to latest versions
…ward refs as needed for flexibility purposes
…component classname to svg-map and concat custom
…t as no longer needed
…and uncontrolled component options.
…d uncontrolled component options
…ts of the components
…eded in React >v17
…eded in React >v17
Thanks a lot for your hard work @mihai-ro! However, without looking at the code in details, here is a 1st quick review:
In general:
However, I know this code is pretty old and I saw interesting ideas in your PR to avoid the code duplication. |
I admit, I got carried away with the refactoring, and the linting config is too much 😅
I would argue bumping dependencies and keeping your application up-to-date is a good practice, and refactoring is not a bad thing, as long as it does not turn the project upside down. On the opposite, failing to update dependencies would potentially expose security flaws. Regarding the bugs - there is no software that is absolutely bug-less, that is why we test and gradually improve the application to make it more sturdy and reliable to the users. As I mentioned above, I will try to squeeze some time to get some updates up; it will most likely not be this week, but I will do my best in the near time. |
Sorry for the long silence, I really had no time to work on personal projects 😩
|
Work done:
defaultValue
,value
andonChange
Close #44
Close #53