operator api usage deprecated autoscaling/v2beta2 blocks update of Azure Kubernetes Service

[SaschaJohn]

Hello VM team,

we're currently doing an upgrade from AKS 1.25 to 1.27. During the upgrade, the service scans for usage of deprecated APIs, that will be removed in the current upgrade path.
We came across the error of autoscaling/v2beta2 used from vmoperator which is deprecated since 1.23 and was removed in 1.26.

You already made the operator compatible with #583

However I see a problem in the order of the API usage.

1,25 supports API version supports v2beta2, therefore function IsHPAV2BetaSupported returns true
and

operator/controllers/factory/builders.go

Line 405 in bfc521d

func buildHPASpec(targetRef v2beta2.CrossVersionObjectReference, spec *victoriametricsv1beta1.EmbeddedHPA, or []metav1.OwnerReference, lbls map[string]string, namespace string) client.Object {

takes the beta in favor of the stable version. In 1.26 the beta api was removed. This blocks the upgrade path.

Do you any need to support the beta api? Otherwise I suggest to remove it from the controllers factory builders,

Best

/Sascha

[f41gh7]

Hello, thanks for detailed bug report @Haleygo can you please take a look?

[SaschaJohn]

Bug fixed in next release after v0.41.1 from 1 Feb 2024.
Thank you very much @f41gh7 @Haleygo !