Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MacheteClient.read_definition_file should be a static factory method instead of a side-effecting instance method #955

Open
PawelLipski opened this issue May 20, 2023 · 1 comment
Open

MacheteClient.read_definition_file should be a static factory method instead of a side-effecting instance method #955

PawelLipski opened this issue May 20, 2023 · 1 comment
Labels
code quality Quality of the code nees improving

Comments

@PawelLipski
Copy link
Collaborator

A call to read_definition_file should return a fresh instance of MacheteClient.
@PawelLipski PawelLipski added the code quality Quality of the code nees improving label May 20, 2023
@PawelLipski
Copy link
Collaborator Author

Rel: #954

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code quality Quality of the code nees improving
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PawelLipski