Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are not rendering #34

Open
Vinayak-k160 opened this issue Aug 19, 2020 · 2 comments
Open

Images are not rendering #34

Vinayak-k160 opened this issue Aug 19, 2020 · 2 comments

Comments

@Vinayak-k160
Copy link

How to render images
its is showing link for image but not image

@Vinayak-k160
Copy link
Author

hey please note I used this link "https://images.unsplash.com/photo-1555099962-4199c345e5dd?ixlib=rb-1.2.1&auto=format&fit=crop&w=750&q=80" for image and it used to return me Link instead of Image.
So actually there was error in Image Regex it does not contain & char so I corrected the Regex as below
"/![(.*)](((?:(http[s]?|ftp)?:?/{0,2})[\w/-+?#&=.:]+))/g"
hope you will fix the bug

@arnoclr
Copy link

arnoclr commented Mar 25, 2021

Also note that some links contain %, like firebase storage urls.

This regex work fine, based on yours :

/![(.*)](((?:(http[s]?|ftp)?:?/{0,2})[\w/-+?#&%=.:]+))/g

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants