-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Compatible with BuyEmAll #16
Comments
It seems written in a way that should be easier to support. Note to self that the |
Really would like this to work with BuyEmAll. |
Thank you so much for adding support for this :-) |
Hey @Vladinator. As the author of the BuyEmAll addon, I would like to thank you for adding support for BuyEmAll to CompactVendor. I also had a cursory look at adding support for CompactVendor from BuyEmAll's code but that didn't seem quite as easy to do. Currently the BuyEmAll addon is written primarily to work with Blizzard's own vendor frames, and from experiences these frame properties can change with a future update. This means the compatibility between CompactVendor and BuyEmAll could break in the future with a new WoW update using this approach of calling If you want to, I'm totally down to collaborate with you on a sustainable way to maintain support between our addons. I could introduce an API with a stable interface to avoid breakage in the future in a way that works for you as well. Love to hear your toughts on this. |
Hi @kaelonR, I think it's a great idea. It would allow any vendor related addon to easily integrate with the UI of BuyEmAll. Since the only thing needed to be passed right now is the index of the vendor item in question, along with an optional anchor preference where the frame should appear. The only last thing that I can imagine is a way to know if the frame is already visible, and what it is currently attached to (anchored to?) I believe these should be enough for anyone to integrate with BuyEmAll for vendor purchases. |
Would love if this would become compatible with the BuyEmAll addon
https://www.curseforge.com/wow/addons/buyemall
The text was updated successfully, but these errors were encountered: