Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Compatible with BuyEmAll #16

Open
mLgz0rn opened this issue Jan 8, 2023 · 5 comments
Open

Enhancement: Compatible with BuyEmAll #16

mLgz0rn opened this issue Jan 8, 2023 · 5 comments
Assignees

Comments

@mLgz0rn
Copy link

mLgz0rn commented Jan 8, 2023

Would love if this would become compatible with the BuyEmAll addon

https://www.curseforge.com/wow/addons/buyemall

@Vladinator
Copy link
Owner

It seems written in a way that should be easier to support.

Note to self that the BuyEmAll addon has BuyEmAll:MerchantItemButton_OnModifiedClick(frame, button) method that we can call and provide a frame and make sure that it has the properties it expects and it should display its own dialog properly.

@zalidthebur
Copy link

Really would like this to work with BuyEmAll.

@zalidthebur
Copy link

Thank you so much for adding support for this :-)

@kaelonR
Copy link

kaelonR commented Nov 28, 2024

Hey @Vladinator. As the author of the BuyEmAll addon, I would like to thank you for adding support for BuyEmAll to CompactVendor. I also had a cursory look at adding support for CompactVendor from BuyEmAll's code but that didn't seem quite as easy to do.

Currently the BuyEmAll addon is written primarily to work with Blizzard's own vendor frames, and from experiences these frame properties can change with a future update. This means the compatibility between CompactVendor and BuyEmAll could break in the future with a new WoW update using this approach of calling MerchantItemButton_OnModifiedClick.

If you want to, I'm totally down to collaborate with you on a sustainable way to maintain support between our addons. I could introduce an API with a stable interface to avoid breakage in the future in a way that works for you as well.

Love to hear your toughts on this.

@Vladinator
Copy link
Owner

Hi @kaelonR, I think it's a great idea. It would allow any vendor related addon to easily integrate with the UI of BuyEmAll.

Since the only thing needed to be passed right now is the index of the vendor item in question, along with an optional anchor preference where the frame should appear. The only last thing that I can imagine is a way to know if the frame is already visible, and what it is currently attached to (anchored to?)

I believe these should be enough for anyone to integrate with BuyEmAll for vendor purchases.

@Vladinator Vladinator self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants