Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to have the 'Appearance' filter also filter for 'collected' transmogs? #26

Open
d-schmidt opened this issue Jul 31, 2024 · 3 comments
Assignees

Comments

@d-schmidt
Copy link

Currently it only removes the 'know' transmogs but not the 'collected' transmogs.

We have 3 states of transmogs:
Uncollected:
grafik

Collected (missing filter):
grafik
Known:
grafik

@d-schmidt
Copy link
Author

the current version added a "learnable" which filters the last case like the "apperance: collected".

The "apperance collected: not collected" still shows collected appearances.

@d-schmidt
Copy link
Author

It seems to be a lot harder. even the newer code still has problems with some items not having appearances.

This addon fixed it by starting a dressup:
https://gitlab.com/toreltwiddler/CanIMogIt/-/blob/1bc7db82239ef53ce4ddede3cc2df0fde14979c8/code.lua#L970

@Vladinator
Copy link
Owner

I tried to improve transmog detection by relying on CanIMogIt if it is available, as using the base game API for transmog detection is not reliable in a lot of situations it seems. You need to combine the dressing room API with it to achieve reliable results, but instead of implementing it all in the addon I opted to add compatibility with CanIMogIt until I get more time to dig deeper in the default behavior.

@Vladinator Vladinator self-assigned this Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants