Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DelegatingNegotiateSecurityFilter use of custom auth #956

Merged
merged 2 commits into from
Jun 11, 2020
Merged

Fix DelegatingNegotiateSecurityFilter use of custom auth #956

merged 2 commits into from
Jun 11, 2020

Commits on Jun 11, 2020

  1. Fix DelegatingNegotiateSecurityFilter use of custom auth 

    For the SpringSecurity 4 and 5 modules DelegatingNegotiateSecurityFilter, if both a custom AuthenticationManager and a custom AuthenticationSuccessHandler are specified, the custom Authentication is added to the SecurityContext, but is not passed to the custom success handler.  This means the context has a different Authentication than the success handler.

This is fixed for both spring security modules.

Issues:
Waffle#453
    @cmolodo
    cmolodo committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    e5f6fe3 View commit details
    Browse the repository at this point in the history

  2. Add tests to check custom auth token handling in delegating filters 

    Added unit tests to both Spring Security modules to check that the same authentication token provided by the custom AuthenticationManager is provided to both the SecurityContext and to the custom AuthenticationSuccessHandler.
    @cmolodo
    cmolodo committed Jun 11, 2020
    Configuration menu
    Copy the full SHA
    57f2af4 View commit details
    Browse the repository at this point in the history