[TD]fix crash on bad selection (fix FreeCAD#16727)

WandererFan · Sep 23, 2024 · 98e9046 · 98e9046
1 parent 9b409da
commit 98e9046
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/Mod/TechDraw/Gui/CommandAnnotate.cpp b/src/Mod/TechDraw/Gui/CommandAnnotate.cpp
@@ -1633,8 +1633,9 @@ void CmdTechDrawSurfaceFinishSymbols::activated(int iMsg)
     }
     else {
         auto objFeat = dynamic_cast<TechDraw::DrawView *>(selection.front().getObject());
-        if (!objFeat->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId())
-            && !objFeat->isDerivedFrom(TechDraw::DrawLeaderLine::getClassTypeId())) {
+        if ( !objFeat ||
+             !(objFeat->isDerivedFrom(TechDraw::DrawViewPart::getClassTypeId()) ||
+               objFeat->isDerivedFrom(TechDraw::DrawLeaderLine::getClassTypeId())) ) {
             QMessageBox::warning(Gui::getMainWindow(), QObject::tr("SurfaceFinishSymbols"),
                                  QObject::tr("Selected object is not a part view, nor a leader line"));
             return;