Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] a bug in the dataset/tiktok_video_dataset.py #84

Open
ljh0v0 opened this issue Jan 30, 2024 · 0 comments
Open

[BUG] a bug in the dataset/tiktok_video_dataset.py #84

ljh0v0 opened this issue Jan 30, 2024 · 0 comments

Comments

@ljh0v0
Copy link

ljh0v0 commented Jan 30, 2024

When sampling a segment of video to train the temporal module, the length of the dataset is divided by the train_sample_interval = 4.

But in this line:

idx = min(idx, len(self) - 1)

the code limits the start frame id to be min(idx, len(self) - 1). The len(self) = num_frames / train_sample_interval, so it means only the first quarter of the images in the dataset can be the first frame. Any video segment whose first frame id is larger than num_frames / train_sample_interval will be replaced by the segment starting with the id num_frames / train_sample_interval-1. This causes only the first quarter of datasets will be used in the training.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant