Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve page loading time #52

Closed
ttraenkler opened this issue Jan 9, 2020 · 9 comments
Closed

Improve page loading time #52

ttraenkler opened this issue Jan 9, 2020 · 9 comments
Labels
enhancement New feature or request PR welcome

Comments

@ttraenkler
Copy link
Contributor

ttraenkler commented Jan 9, 2020 •
edited
Loading

Ater fixing #22, this is the new lighthouse report for

landing page

speaker page

about page
@ttraenkler ttraenkler mentioned this issue Jan 9, 2020
Closed
@ttraenkler ttraenkler self-assigned this Jan 9, 2020
@ttraenkler ttraenkler mentioned this issue Jan 9, 2020
Merged
@ttraenkler
Copy link
Contributor Author

I have addressed the missing page title in #53.

@ttraenkler
Copy link
Contributor Author

The main issue remaining is the caching issue, which we cannot solve with Github pages, only maybe partly through #41.

@ttraenkler
Copy link
Contributor Author

I found some accessibility issues for the speakers and about page (missing headings and image alt text mainly), see

speaker page

about page

@ttraenkler ttraenkler added help wanted Extra attention is needed PR welcome and removed help wanted Extra attention is needed labels Jan 9, 2020
This was referenced Jan 9, 2020
Closed
Closed
@ttraenkler
Copy link
Contributor Author

updated / created issues for accessibility of about and speakers page #37 #55

This was referenced Jan 10, 2020
Closed
Merged
Closed
@ttraenkler ttraenkler changed the title address Lighthouse report issues address Lighthouse report Jan 10, 2020
@ttraenkler ttraenkler mentioned this issue Jan 10, 2020
Closed
@ttraenkler
Copy link
Contributor Author

The accessibility issues have been addressed in #67, #61, #63, and #55.

for the remaining reports i created separated tasks

remaining in scope for this task are the reported performance problems, so i rename the task accordingly

@ttraenkler ttraenkler changed the title address Lighthouse report improve page performance Jan 10, 2020
@ttraenkler
Copy link
Contributor Author

#41 will address the pwa report

@ttraenkler ttraenkler removed their assignment Jan 10, 2020
@ttraenkler
Copy link
Contributor Author

#67 addresses the lighthouse font loading performance and email link security issue

@ttraenkler ttraenkler added enhancement New feature or request and removed work in progress needs review labels Jan 11, 2020
@ttraenkler ttraenkler changed the title improve page performance Improve page loading time Jan 12, 2020
@ttraenkler
Copy link
Contributor Author

I think the performance is acceptable and there is no easy action we can do to improve further except for moving to another hosting service. Therefore I am closing

@ttraenkler ttraenkler mentioned this issue Jan 15, 2020
Merged
@ttraenkler
Copy link
Contributor Author

PR #100 solved this issue

@ttraenkler ttraenkler mentioned this issue Jan 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request PR welcome
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ttraenkler