Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Broken Unit Test on WP Trunk #539

Closed
wants to merge 2 commits into from
Closed

Fix Broken Unit Test on WP Trunk #539

wants to merge 2 commits into from

Conversation

JPry
Copy link
Contributor

@JPry JPry commented Dec 6, 2015

Use esc_url_raw() on the expected value test.

This will ensure that what we expect is always the same as
what WordPress gives us.

@JPry
Use esc_url_raw() on expected value test
4f92edd 
This will ensure that what we expect is always the same as
what WordPress gives us.
@jtsternberg
Copy link
Member

@JPry esc_url_raw( 'http://' . $value ) should just be esc_url_raw( $value ).

@JPry
Copy link
Contributor Author

JPry commented Dec 10, 2015

Merged in d772c27

@JPry JPry closed this Dec 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JPry @jtsternberg @gregrickaby