Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated graph heading #190

Open
matbun opened this issue Nov 14, 2022 · 4 comments · May be fixed by #191
Open

Duplicated graph heading #190

matbun opened this issue Nov 14, 2022 · 4 comments · May be fixed by #191

Comments

@matbun
Copy link

matbun commented Nov 14, 2022

When I set the heading property in the Network class, my graph gets rendered with a double heading.
To reproduce:

from pyvis.network import Network

net = Network(heading="My heading")
net.add_node(1, label="Node 1")  # node id = 1 and label = Node 1
net.add_node(2)  # node id and label = 2
net.show('net.html')

I obtain the following behavior:

image
@matbun
Copy link
Author

matbun commented Nov 14, 2022

I found the source of the problem but I have not time to make a PR now. Could anyone remove the duplicated heading code from https://github.com/WestHealth/pyvis/blob/master/pyvis/templates/template.html#L54 to https://github.com/WestHealth/pyvis/blob/master/pyvis/templates/template.html#L56 ?

@scalasm
Copy link

scalasm commented Nov 14, 2022

I have the same exact issue - I think one of those is redundant and can be removed.

@scalasm scalasm linked a pull request Nov 14, 2022 that will close this issue
Open
@scalasm
Copy link

scalasm commented Nov 14, 2022

I have created a PR for fixing the issue - hopefully it will get merged!

@yolave
Copy link

yolave commented Mar 5, 2024

The problem still persists. What happened with this issue?

The PR is ready to be reviewed and merged since ages. Is there something that can be done to push forward this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed duplicated heading in HTML output. scalasm/pyvis
3 participants
@scalasm @yolave @matbun