-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not load external bootstrap resources for cdn_resources = 'in_line' | 'local' #201
base: master
Are you sure you want to change the base?
Do not load external bootstrap resources for cdn_resources = 'in_line' | 'local' #201
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through the commit, I agree with the changes made, but I'm going to need to verify the hash between the bootstrap and visj min.js and .min.css files on my side before merging.
Do you need anything from my side for validating the checksums? @BerserkerGaruk |
f8736bc
to
19b8f78
Compare
@BerserkerGaruk @summerswallow-whi , I have rebased the branch to resolve the merge conflicts that occurred in the meantime. I would appreciate it, if you could take a look, since the MR is open for a couple of month now |
Is there anything that could be done to help with this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this fix!
I had verified e2e this change on my offline code with cc @summerswallow-whi @BerserkerGaruk Thanks! |
The
cdn_resources
option should control how external resources and stylesheets should be loaded.Currently bootstrap is being fetched from CDN irrespective of the
cdn_resources
option.Also I have observed some inconsistencies in the
local
option where thevis-network
css and js files are not being taken from thelib
folder but rather externally fetched. Please correct me here if my understanding of how these options are intended to work is wrong.To summarise the changes:
cdn_resources = 'remote'
lib/
whencdn_resources = 'local'
example.ipynb
to update the samples