Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winetricks-test assumes that winetricks is located in the same folder #891

Closed
mihaitodor opened this issue Dec 9, 2017 · 2 comments
Closed

winetricks-test assumes that winetricks is located in the same folder #891

mihaitodor opened this issue Dec 9, 2017 · 2 comments
Assignees
@austin987
Labels
bug Acknowledged bug download Bugs with an available download tests Bugs affecting the tests

Comments

@mihaitodor
Copy link
Contributor

See here.

Since they are located in different folders, users won't be able to simply run winetricks-test without some manual steps, like copying winetricks around.
@mihaitodor mihaitodor mentioned this issue Dec 9, 2017
Open
@austin987 austin987 self-assigned this Dec 11, 2017
@austin987 austin987 added bug Acknowledged bug download Bugs with an available download labels Dec 11, 2017
@austin987
Copy link
Contributor

Confirmed, I'll look at some point in the near future.

@austin987 austin987 added the tests Bugs affecting the tests label May 28, 2018
@austin987 austin987 mentioned this issue Aug 12, 2018
Closed
@austin987
Copy link
Contributor

This was fixed a while back and never closed:

commit 62426e87c60c30a97c072dc0d1e97d48c0fbe509
Author: Austin English <[email protected]>
Date:   Sun Aug 12 01:21:27 2018 -0500

    tests/winetricks-test: don't depend on being in src/ to run

and another for linkcheck.sh:

commit cf53698820c44de50c91ab446cac4f7e8ecabb89
Author: Austin English <[email protected]>
Date:   Sun Aug 12 01:52:34 2018 -0500

    src/linkcheck.sh: don't depend on being in src/ to run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@austin987 austin987

Labels
bug Acknowledged bug download Bugs with an available download tests Bugs affecting the tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

run tests/linkcheck.sh from any dir austin987/winetricks
2 participants
@austin987 @mihaitodor