Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing Tests in LV2024 - Waveform Layout #30

Open
JamesMc86 opened this issue Jul 11, 2024 · 1 comment
Open

Failing Tests in LV2024 - Waveform Layout #30

JamesMc86 opened this issue Jul 11, 2024 · 1 comment

Comments

@JamesMc86
Copy link
Contributor

Seeing some tests failing in 2024.

test Cluster and Waveform Packing fails because it is panicking internally. Need to review this and probably my variant and waveform layout work is wrong or not portable.
@JamesMc86
Copy link
Contributor Author

I had a quick look and there are defintately a few fishy things in here:

  • The second pad is not required in this case. Probably something wierd about padding variants.
  • The order or types in the waveform seem off - the dt is wrong.

image

This isn't a type that NI offer any C compatibility around but would be nice due to the commonality of it. Need to compare back to the original version in 2020 and I guess work out where it breaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesMc86