Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Different Read Lengths for Multichannel Readers #9

Open
JamesMc86 opened this issue Aug 31, 2023 · 2 comments
Open

Handle Different Read Lengths for Multichannel Readers #9

JamesMc86 opened this issue Aug 31, 2023 · 2 comments

Comments

@JamesMc86
Copy link
Contributor

Right now these return the length of the block. Either return a value for each channel or more likely check the output lengths and if less than the block size, assume that is all that is read.
@JamesMc86
Copy link
Contributor Author

Big issue with this - how do we do this and not allocate vectors? Probably can't because we could ask to read 100 channels in theory so assumptions like smallvec could help but probably aren't enough to cover all cases.

This isn't a big performance issue. But I would love this to work in WASM for example.

@JamesMc86
Copy link
Contributor Author

The other big question is: do we need to support this?

The NI TDMS API does not allow writing in a way that you have different channel lengths per channel in a single block anyway (it doesn't event support mixing types!). So why bust our ass to support this use case?

The important thing is that we know if a channel is complete, not an exact read number - although we do like to pass that back,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JamesMc86