Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Use unitless line-height #132

Closed
ntwb opened this issue May 2, 2017 · 1 comment
Closed

Use unitless line-height #132

ntwb opened this issue May 2, 2017 · 1 comment

Comments

@ntwb
Copy link
Member

ntwb commented May 2, 2017

Via WordPress/gutenberg#571

See https://make.wordpress.org/core/handbook/best-practices/coding-standards/css/#values

"Line height should also be unit-less, unless necessary to be defined as a specific pixel value. This is more than just a style convention, but is worth mentioning here. More information: http://meyerweb.com/eric/thoughts/2006/02/08/unitless-line-heights/"

Also https://developer.mozilla.org/en-US/docs/Web/CSS/line-height#Prefer_unitless_numbers_for_line-height_values

@ntwb
Copy link
Member Author

ntwb commented May 2, 2017

Notes:

bbPress, BuddyPress, and BuddyPress' Nouveau all contain instances of line-height containing units, before merging this, this should be researched and tested before merging.

@ntwb ntwb closed this as completed in #133 May 15, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant