Skip to content
This repository has been archived by the owner on Feb 25, 2021. It is now read-only.

Use @wordpress/scripts #231

Merged
merged 44 commits into from
Nov 24, 2019
Merged

Use @wordpress/scripts #231

merged 44 commits into from
Nov 24, 2019

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Aug 16, 2019

Updates the repo to use @wordpress/scripts

@ntwb
Copy link
Member Author

ntwb commented Aug 16, 2019

This PR is blocked by WordPress/gutenberg#17061

@ntwb
Copy link
Member Author

ntwb commented Aug 16, 2019

This PR is blocked by WordPress/gutenberg#17060

@GaryJones
Copy link
Member

For the uninitiated, can you please expand on what the @wordpress/scripts package is and why it should be switched to?

@ntwb
Copy link
Member Author

ntwb commented Aug 16, 2019

This repo was still using the deprecated ESLint config, the replacement is @wordpress/eslint-plugin so the vast majority of code in this PR is updated to adhere to the latest WordPress JS Coding Standards, which is what Gutenberg uses, as will WordPress Core.

The @wordpress/scripts package also includes styleint, Jest, npm-package-json-lint configs as dependencies which ship with a default configuration, this default configuration which is inherited allows for zero configuration here in this repo. As such this repo removes any and all ESLint, stylelint, Jest, and npm-package-json-lint configurations greatly simplifying the configuration of the build tools in the repo by not requiring any configuration whatsoever.

** There is one minor config tweak added in .stylelintignore here so that the stylelint Jest tests that are part of this repo run the stylelint tests using stylelint-config-wordpress against the valid CSS & SCSS test fixtures but ignore the invalid test fixtures.

@GaryJones
Copy link
Member

Is it foreseeable that eventually there would be a @wordpress/stylelint or similar which would make this stylelint-config-wordpress redundant?

@ntwb
Copy link
Member Author

ntwb commented Aug 19, 2019

Yes @GaryJones, this repo will be deprecated and moved to the Gutenberg packages and become @wordpress/stylelint-config

See also: WordPress/gutenberg#16924 (comment)

ntwb and others added 22 commits October 5, 2019 19:00
…ds/stylelint-config-wordpress into add-node-twelve
chore: add Node.js v12 to Travis CI test matrix
…ules

chore: update `stylelint-find-rules` to 2.2.0
Update npm-package-json-lint to the latest version 🚀
…ng-Standards/stylelint-config-wordpress into try/use-wordpress-scripts
@ntwb ntwb merged commit 99d049c into master Nov 24, 2019
@ntwb ntwb deleted the try/use-wordpress-scripts branch November 24, 2019 23:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants