Make API clearer to consumers of hook

WordPress · May 25, 2023 · 3e6f682 · 3e6f682
1 parent 4f16173
commit 3e6f682
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 20 deletions.
diff --git a/packages/block-editor/src/components/link-control/index.js b/packages/block-editor/src/components/link-control/index.js
@@ -146,7 +146,7 @@ function LinkControl( {
 		setInternalControlValue,
 		setInternalURLInputValue,
 		setInternalTextInputValue,
-		setInternalSettingValue,
+		createSetInternalSettingValueHandler,
 	] = useInternalValue( value );
 
 	const valueHasChanges =
@@ -388,7 +388,9 @@ function LinkControl( {
 							handleSubmitWithEnter={ handleSubmitWithEnter }
 							value={ internalControlValue }
 							settings={ settings }
-							onChange={ setInternalSettingValue( settingsKeys ) }
+							onChange={ createSetInternalSettingValueHandler(
+								settingsKeys
+							) }
 						/>
 					) }
 

diff --git a/packages/block-editor/src/components/link-control/use-internal-value.js b/packages/block-editor/src/components/link-control/use-internal-value.js
@@ -31,29 +31,30 @@ export default function useInternalValue( value ) {
 		} );
 	};
 
-	const setInternalSettingValue = ( settingsKeys ) => ( nextValue ) => {
-		// Only apply settings values which are defined in the settings prop.
-		const settingsUpdates = Object.keys( nextValue ).reduce(
-			( acc, key ) => {
-				if ( settingsKeys.includes( key ) ) {
-					acc[ key ] = nextValue[ key ];
-				}
-				return acc;
-			},
-			{}
-		);
-
-		setInternalValue( {
-			...internalValue,
-			...settingsUpdates,
-		} );
-	};
+	const createSetInternalSettingValueHandler =
+		( settingsKeys ) => ( nextValue ) => {
+			// Only apply settings values which are defined in the settings prop.
+			const settingsUpdates = Object.keys( nextValue ).reduce(
+				( acc, key ) => {
+					if ( settingsKeys.includes( key ) ) {
+						acc[ key ] = nextValue[ key ];
+					}
+					return acc;
+				},
+				{}
+			);
+
+			setInternalValue( {
+				...internalValue,
+				...settingsUpdates,
+			} );
+		};
 
 	return [
 		internalValue,
 		setInternalValue,
 		setInternalURLInputValue,
 		setInternalTextInputValue,
-		setInternalSettingValue,
+		createSetInternalSettingValueHandler,
 	];
 }