From d5e7bcace7cb8714e007495f3c8ce857c0340b28 Mon Sep 17 00:00:00 2001 From: Jarda Snajdr Date: Mon, 18 Nov 2024 16:33:46 +0100 Subject: [PATCH] PostTitle: exit early when post type doesn't support titles (#67086) Unlinked contributors: mijan-xs. Co-authored-by: jsnajdr Co-authored-by: Mamaduka Co-authored-by: t-hamano Co-authored-by: ndiego Co-authored-by: gziolo Co-authored-by: SantosGuillamot Co-authored-by: getdave Co-authored-by: youknowriad Co-authored-by: Tropicalista --- .../editor/src/components/post-title/index.js | 36 ++++++++++--------- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/packages/editor/src/components/post-title/index.js b/packages/editor/src/components/post-title/index.js index 50595d936b36d9..7fc79eaeddffb5 100644 --- a/packages/editor/src/components/post-title/index.js +++ b/packages/editor/src/components/post-title/index.js @@ -28,7 +28,7 @@ import usePostTitleFocus from './use-post-title-focus'; import usePostTitle from './use-post-title'; import PostTypeSupportCheck from '../post-type-support-check'; -function PostTitle( _, forwardedRef ) { +const PostTitle = forwardRef( ( _, forwardedRef ) => { const { placeholder } = useSelect( ( select ) => { const { getSettings } = select( blockEditorStore ); const { titlePlaceholder } = getSettings(); @@ -171,23 +171,21 @@ function PostTitle( _, forwardedRef ) { return ( /* eslint-disable jsx-a11y/heading-has-content, jsx-a11y/no-noninteractive-element-to-interactive-role */ - -

- +

/* eslint-enable jsx-a11y/heading-has-content, jsx-a11y/no-noninteractive-element-to-interactive-role */ ); -} +} ); /** * Renders the `PostTitle` component. @@ -197,4 +195,8 @@ function PostTitle( _, forwardedRef ) { * * @return {Component} The rendered PostTitle component. */ -export default forwardRef( PostTitle ); +export default forwardRef( ( _, forwardedRef ) => ( + + + +) );