Scripts: Align default engines for check-engines with the package

WordPress · Jan 12, 2021 · d7601e8 · d7601e8
1 parent 59923c1
commit d7601e8
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 9 deletions.
diff --git a/packages/scripts/CHANGELOG.md b/packages/scripts/CHANGELOG.md
@@ -17,6 +17,10 @@
 -   Make it possible to transpile `.jsx` files with `build` and `start` commands ([#28002](https://github.com/WordPress/gutenberg/pull/28002)).
 -   Add support for static assets (fonts and images) for `build` and `start` commands ([#28043](https://github.com/WordPress/gutenberg/pull/28043)).
 
+### Bug Fix
+
+-   Ensure that `check-engines` uses the same default version of Node.js and npm as this package ([#28143](https://github.com/WordPress/gutenberg/pull/28143)).
+
 ### Internal
 
 -   The bundled `webpack-bundle-analyzer` dependency has been updated from requiring `^3.6.1` to requiring `^4.2.0`.

diff --git a/packages/scripts/README.md b/packages/scripts/README.md
@@ -105,7 +105,7 @@ This is how you execute the script with presented setup:
 
 #### Advanced information
 
-It uses [check-node-version](https://www.npmjs.com/package/check-node-version) behind the scenes with the recommended configuration provided. Similarly to this package, the default requirements are `node` 10.0.0 or later, and `npm` 6.9.0 or later. You can specify your own ranges as described in [check-node-version docs](https://www.npmjs.com/package/check-node-version). Learn more in the [Advanced Usage](#advanced-usage) section.
+It uses [check-node-version](https://www.npmjs.com/package/check-node-version) behind the scenes with the recommended configuration provided. The default requirements are set to the same Node.js and npm versions as listed in the [installation](#installation) section for this package. You can specify your own ranges as described in [check-node-version docs](https://www.npmjs.com/package/check-node-version). Learn more in the [Advanced Usage](#advanced-usage) section.
 
 ### `check-licenses`
 

diff --git a/packages/scripts/scripts/check-engines.js b/packages/scripts/scripts/check-engines.js
@@ -9,18 +9,26 @@ const { sync: resolveBin } = require( 'resolve-bin' );
  */
 const { getArgsFromCLI, hasArgInCLI } = require( '../utils' );
 
-const args = getArgsFromCLI();
+const getConfig = () => {
+	const hasConfig =
+		hasArgInCLI( '--package' ) ||
+		hasArgInCLI( '--node' ) ||
+		hasArgInCLI( '--npm' ) ||
+		hasArgInCLI( '--yarn' );
 
-const hasConfig =
-	hasArgInCLI( '--package' ) ||
-	hasArgInCLI( '--node' ) ||
-	hasArgInCLI( '--npm' ) ||
-	hasArgInCLI( '--yarn' );
-const config = ! hasConfig ? [ '--node', '>=10.0.0', '--npm', '>=6.9.0' ] : [];
+	if ( hasConfig ) {
+		return [];
+	}
+	const {
+		engines: { node, npm },
+	} = require( '../package.json' );
+
+	return [ '--node', node, '--npm', npm ];
+};
 
 const result = spawn(
 	resolveBin( 'check-node-version' ),
-	[ ...config, ...args ],
+	[ ...getConfig(), ...getArgsFromCLI() ],
 	{
 		stdio: 'inherit',
 	}