Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ? and Alt+? to open keyboard shortcuts panel #10914

Open
iandunn opened this issue Oct 22, 2018 · 9 comments
Open

Use ? and Alt+? to open keyboard shortcuts panel #10914

iandunn opened this issue Oct 22, 2018 · 9 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.

Comments

@iandunn
Copy link
Member

iandunn commented Oct 22, 2018

Problem

I can never remember the keyboard shortcut that reveals the list of keyboard shortcuts.

control+alt+h feels cumbersome, unintuitive, and inconsistent with other popular web apps.

Proposed Solution

It seems like most web apps have standardized on ? as the key to open that panel, e.g., Trello and GitHub. That feels much more intuitive to me. Of course that won't work if the user is focused on an input field, but in those cases a single modifier like Alt+? or Control+? would solve that.

The current shortcut should probably remain for back-compat. Alt+? and Control+? don't seem to have any conflicts on OS X + Firefox, but I haven't tested beyond that.

@iandunn iandunn added the [Type] Enhancement A suggestion for improvement. label Oct 22, 2018
@iandunn
Copy link
Member Author

iandunn commented Oct 22, 2018

Related: #9361

@chrisvanpatten
Copy link
Contributor

chrisvanpatten commented Oct 22, 2018

Recommended reading: #3218 #8316. The tl;dr is that there are a lot of issues with Meta+? as a shortcut, and the likely long term solution is to allow users to remap keyboard shortcuts to something that makes sense based on their keyboard layout or other installed apps.

(Edit: to be clear I also wish it could be meta+? because muscle memory. Just pointing out that there was a lot of discussion before deliberately deciding not to use meta+?.)

@iandunn
Copy link
Member Author

iandunn commented Oct 22, 2018

Thanks for pointing that out.

It seems like we could still use ? when an text/textarea input isn't focused.

Maybe the rest of this ticket is a duplicate of #3218, though? Those conversations are pretty length, so I'll admit I didn't read all of them. Feel free to close this if you think it's already covered.

@mtias mtias added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). and removed [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Oct 23, 2018
@mtias
Copy link
Member

mtias commented Oct 23, 2018

@tofumatt any thoughts on using ? when nothing is selected?

@tofumatt
Copy link
Member

? works for me. Control + ? could work when inputs are selected, but we could also just go with ? to start with and iterate from there...

@talldan
Copy link
Contributor

talldan commented Oct 24, 2018

It's really / that would be the bound key.

When I initially tried implementing this, lots of people mentioned they don't have a / on their keyboards (many European keyboard layouts don't have it).

I discovered slack (and possibly gdocs) workaround this by binding both / and ., so we should probably do the same.

@iandunn
Copy link
Member Author

iandunn commented Apr 27, 2019

I haven't tested it, but IIRC Firefox uses / for Search, and many popular web apps do as well (e.g., Remember the Milk), so we might want to use it ourselves one day for something like #wp33566:comment:4.

@gziolo gziolo added [a11y] Keyboard & Focus [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). labels Oct 20, 2019
@skorasaurus skorasaurus added the Needs Decision Needs a decision to be actionable or relevant label May 28, 2022
@ramonjd
Copy link
Member

ramonjd commented Apr 2, 2024

using ? when nothing is selected?

Related PR that adds a shortcut but skips shortcut behaviour if text field is focussed:

https://github.com/WordPress/gutenberg/pull/59978/files#diff-b719a654780fb2dd68af5b74ec380db6c6788b13ecf55a10ebb568af8350a47bR147

@t-hamano
Copy link
Contributor

Is this discussion still valid? If you can't remember the shortcut, you can check it from the options menu.

Screenshot in Windows:

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Decision Needs a decision to be actionable or relevant [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

10 participants