-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-grouping Editor Inserter Menu #11406
Comments
Agree 100% both with the naming of Most Used / Common and the assessment of how to restructure the blocks by attribution/context. |
Thanks for the thoughtful proposal. I agree with your overview and that "Common" blocks can be a bit opaque. I like having a group for "Media" but there's some overlaps with "Text" that need a bit more thinking (is "Media & Text" media or text? What about "Cover" used without a bg image and only a color and some overlay text?). Likewise "Button" feels a bit off placed in "Text", but these are just a matter of placement. The next phases are going to be bringing a lot more blocks into the picture, so it might be helpful to revise at the same time. |
Really great proposal, @shinyabw! I've often fumbled through the groupings in the Inserter as well. They just don't map to my mental model. I like how you've presented this and would like to get some more feedback on this before making any changes. cc @melchoyce @kjellr @jasmussen. On another note, we now have a Block Manager merged (#14224) into the code. I'd like to include the ability to rename the categories in the Inserter, or create your own, and move blocks between each category as you like. But that's a ways off. |
I generally like the regrouping, but we'll need to address @mtias' feedback about the blocks that intersect between categories, like Cover and Media & Text. Some ideas:
If someone has the time and resources, this would make for a good card-sorting exercise. Maybe at WCEU, if we have a Gutenberg table? |
I like this regrouping, and also agree with Mel that it might make sense to merge the "Text" and "Media" together into one. |
@mtias maybe any block that can incorporate "media" should fall into the "Media" grouping (ie. Media+Text block and Cover block), unless that block's primary focus is text. As for the Button block, that's a bit more tricky. I don't mind leaving it under "Layout" since that's where it exists today. The Classic block also might need a better group than "Code." It doesn't feel like a code-related block necessarily. Should Preformatted block move to the "Code" group? I left it under "Text" for now.
|
@mtias Want to chime in on this one? |
"Text & Media" sounds like a good group name, but here is already a block with that name. |
One thing to keep in mind here when it comes time to actually build this change is how it will affect any plugins that have built blocks that are assigned to categories from the current list that will no longer exist. Some of them map nicely 1:1 so we could account for that and handle it automatically (embed, widget, layout). But others will be less clear. Example: Should a block in the formatting category be moved to |
Thanks for bringing this up @shinyabw. +1 for regrouping into something that makes more sense. I like what @mapk , but would also love to see that card sorting session happening at WCEU. Maybe as part of the user test table? Are the blocks as mentioned above all the current core blocks? Btw I'm also mostly confused that embedded video's require a different block than video. I also wonder how we are going to deal with third party blocks. Can the developer choose to place them in one of the standard groups, or will third party groups be added as a different section by default? I know we cannot influence the behaviour of third party's, but I think we should take them into consideration as we think about the way the inserter menu is organised, to prevent the same plugin mess as in the WP-Admin from happening here too. |
@boemedia Third party blocks must be assigned to a category when registered. They can either be placed into one of the existing core block categories, or a plugin can register its own block categories and place blocks into those. What I'd be concerned about is a third party block that has been registered for a category that goes away after this change, such as We'd probably need to automatically filter/remap those to a different/new category and maybe also throw some kind of console warning to notify the developer that they are using a deprecated block category. |
Great feedback, @boemedia! Thanks. As for 3rd party blocks, developers can create their own Block Category in the Inserter similar to Jetpack. OR just add their blocks to one of the other categories. |
Love the idea of card sorting at WCEU, @boemedia |
Uh uh it was your idea in the first place ;)
Op di 11 jun. 2019 om 22:44 schreef Mel Choyce <[email protected]>
Love the idea of card sorting at WCEU, @boemedia
<https://github.com/boemedia>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11406?email_source=notifications&email_token=AHDD7FS72UQUF46FAHOLXVTP2AFDDA5CNFSM4GBOO6B2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXOOIIQ#issuecomment-501015586>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHDD7FUFV5VDGY6DGZIZJG3P2AFDDANCNFSM4GBOO6BQ>
.
--
Hartelijke groet,
Monique Dubbelman
BOE!media
[email protected]
+31624500428
Mooi rood is niet lelijk: 7 tips voor het kiezen van de juiste kleuren voor
je website of app
<https://www.boemedia.nl/mooi-rood-is-niet-lelijk-7-tips-voor-het-kiezen-van-de-juiste-kleuren-voor-je-website-of-app/>
|
I am toying with the idea that one of the groups should be called "interactive" or something similar that would combine - for example - the button, interactive media blocks (eg. a 3rd party Slider block or the form selector for Gravity Forms) and maybe even embeds like Instagram. I am a bit torn about the last part, because I generally like the "Embed" category and it makes perfect sense. Just a thought I wanted to get out there :) Even though there aren't many Core blocks that would fall into this category, I see many 3rd party blocks that would perfectly fit into "Interactive". |
I think it's a great idea to only use "Most used blocks" and put the other blocks into other categories. In my opinion the "Preformatted" block should go into the "Code" category. I think the "Button" block is not perfectly located in the Layout categories, but I don't know if the "Text" category is a better fit. Do you plan a further new category at any time? Maybe "Interactive" for buttons, forms would be interesting in the future. |
I offered some fly-by comments and @mtias asked me to share them here. I haven't been involved in development so forgive me if I'm missing context. Although I do use Gutenberg almost every day and I know and hear about the plans. So I should have more context than the average user. I also find the current categorization confusing and difficult to navigate. Totally agree with dropping either "most used" or "common blocks" because having the same blocks in these two big categories is very confusing to me. I don't know if "most used" is most used by me, by others, is it algorithm-driven, is it arbitrary? As a user I don't really care. I just get confused seeing the same blocks in different places and it discourages me from looking further. @shinyabw I wasn't clear what you mean by "attribution" in your original text ... I would have thought that meant by plugin (i.e., attributed to a certain author or plugin) but your example doesn't seem to follow that. Maybe the term has a special meaning for Gutenberg blocks that I'm just not aware of. But from a user point of view I would prefer grouping by functionality. Widgets and embeds are not really functions, they're the underlying technology. And as a user I don't think I should have to know or care about that. I would like all of the options for a particular function (say image galleries) in a single place so I can compare them. As it stands I think I may possibly see them scattered between "most used", "common", "media", "widgets", "embeds", and any number of other plugin categories. I definitely like the idea of third-party blocks being encouraged to use functional categories (though understand sometimes they'll need their own). I think users shouldn't have to think about the technology/jargon behind it (widgets/embeds), the business relationships (third-party plugins), or other WordPress-isms when they're looking for a block that does a particular thing. Last bit, which isn't about categorization but I'll mention here, I'd personally like to see the choices presented in a much more compact format. Looking at non-WordPress block selectors I can see many more items and categories at once and I can more easily navigate and find the one I want. Hope that's useful! :-) |
I haven't been involved in the development so excuse me if I don't have all the context. Chatting with @mtias I've explored quickly some options that could help. Basic principles used in the new alternatives:
|
This seems like a really positive direction, @pablohoneyhoney. I particularly like:
The only hesitancy I have is placing all of the Embed blocks within the Media category. They technically make sense to be there, however there are a lot of them, and I worry that it'll be tough for people to scroll through all that to get to the Interface blocks. |
This was my worry, too. I wonder if a lot of the niche ones could be hidden by default. Or maybe we move some of the most common ones to media (like YouTube) and still leave others in Embeds? We still control order for core blocks, so we wouldn't have a very niche embed be presented before "Gallery". However, for 3rd party blocks that can be an issue. |
Dig that, Pablo, very nice work. Less is more, and this seems like a nice refinement. We can't enforce those simpler labels for 3rd parties, of course, but leading by example is a great step forward. I would also echo Kjell and Matías concerns about the embeds. For better or worse, by whitelisting and providing embeds for 3rd parties, we effectively choose already. So there's no reason not to sort those embeds by some measure of popularity also, and I do suspect people expect YouTube to be in Media. Unrelated tangent: this simpler look might actually afford the color that 3rd parties have been putting into their category icons, which was recently made grayscale — perhaps we can let those colors shine through again in this simpler configuration? The primary thing about the grayscale icons that hasn't worked well in practice, is that it's not the same gray — it's just a desaturated icon. |
Let's get this moving. I reviewed the different suggestions and made a few tweaks.
|
Everyone, thank you. @mtias, thank you for leading this issue. @rralian, apology for the confusion. I meant "attribution" as "character". I took out "by attribution" from the title. For some reason, I thought this issue was discussed at WCEU... Since I could not attend WCEU, I am so glad that I have a chance to keep on contributing.
|
I agree with this. |
I agree. But I do think the concept behind "Most Used" is helpful. Perhaps update the treatment of the section and mimic the empty Paragraph block by showing only the icons for the most recently used blocks. It could be helpful to separate Core blocks from Installed blocks, and standardize the way plugins can show icons for block groups. When there are no blocks installed, we could advertise the ability to install new blocks with a link to the upcoming Block Directory. |
I really dig this, @shaunandrews. I'd love to move this forward because I'm seeing people struggle with the terms used currently when searching for a particular block in usability tests. How about something like this?
I'd like to keep the Block Directory integration as it's own PR so this particular issue doesn't get blocked by adding to its purpose. If this works with everyone, we'll also keep the categorization of the blocks mentioned here: #11406 (comment). Let's move this to development! 🎉 |
Slightly drive-by comment but I am not super convinced about 'design' as a term here. I would expect it to be for many meaning something more aligned to actual colours/typography and styling. I know it doesn't have to mean that but most think that. |
@karmatosed Perhaps it is better to stick with "Layout" then? Also, I'm not convinced that "Tools" really makes sense either. Latest Posts doesn't sound like a "tool" to me. Perhaps we should just have a "Miscellaneous" or "Other" group? Also, I'm not sure where exactly the Button block should go. Technically, it's not even a real |
I took a quick look at this from a dev perspective off the back of a request in WP Core Editor Slack. It looks like these Block categories are defined in WordPress Core. Gutenberg has its own defaults but these will be overridden by WP Core defaults. If someone from the Gutenberg team (@aduth ?) wants to correct me please do. Also, what is the deprecation strategy for the existing Categories? Are we going to map old categories to new ones? We could alias the old categories to the new ones to ensure Blocks registered to old categories still show up. |
The concern about "Design" makes sense. How about "Layout" or "Structure"? Seeing as this category will include, |
@mapk and I were looking at this as well. My understanding is that the categories as defined in the blocks modules are intended to serve as a "base" set of defaults, notably for use of these modules outside the context of WordPress. They're redefined server-side to give plugins the opportunity to filter the results (e.g. to add to or remove from the default set). As you noticed, there's going to be a challenge here in how we decide to update these, given that plugins which register custom blocks will have already assigned one of the existing categories. If there was a direct relationship between each of the previous categories and their new names, we could choose to simply update the labels of the category, but keep the slug values the same. There's a few downsides to this approach, however:
If we decided to rename the existing categories, there would be some side-effects as well, since those old category slugs effectively disappear. The block editor would treat any third-party block which registers with the old name as an invalid registration, and would refuse to allow it to register. I think what would need to happen is to rename the categories, and include a fallback mapping of the legacy category names. This would be an imperfect mapping, but blocks could choose to update to a more appropriate category. For example, This does leave open an unanswered question about plugins which support previous versions of WordPress. If a plugin updates their block to use the There could be a separate discussion around how we could be more proactive to avoid these difficulties if we choose to rename labels again in the future. One thing I think we could improve upon is to be more graceful in how we treat invalid categories. For example, maybe we could allow a block to be registered without a category, or with an invalid category name, and present those blocks as part of some "Uncategorized" grouping. This would avoid a future hypothetical scenario where a category name becomes invalid because it's become renamed. |
Just linking this one here. If we wanted to go with the "Most Used" layout above that shows the top 3 blocks as icons, PR #19045 is planning to remove that component. I'm sure we can get around it just fine, but wanted to note it. |
I think we should avoid the "most used" for now. It can be discussed separately. |
@aduth This is exactly what I had in mind so that is good. I was going to take a crack at a POC but given this is also in WP Core I'm going to leave this to someone with a better grasp of the implications 😄 |
I think the group name "Layout" makes sense, but imho, button doesn't belong there, neither does a separator. From a classical design perspective (read: print), grid, layout and content were separate stages. I see there's some things crossing lines here. But the way I see it:
It makes sense to separate structure/layout blocks from content blocks. I definitely see a button as a content item. Text or a separate 'call to action' section would make more sense. I was looking into the way popular page builders like Beaver Builder and Elementor are grouping their elements, but that doesn't make sense at all (separated by basic/pro subscription, third party elements in separate sections...). But at least they have layout and content in different parts of the builder. |
I've opened a pull request at #19279 to start exploring the implementation of these block category updates. |
Thanks @aduth for starting a PR! Let's think about moving the Button block into the "Tools" category and then we can relabel the "Design" category to "Structure." |
Also #19070 for removing the "most used" category. |
Describe the bug
Hi. I am one of translation contributors for ja. I was originally troubled by how Most Used Blocks and Common Blocks mean very similar in Japanese.
Even in English-English dictionary, it says:
Most = greatest in amount.
Common = occurring, found, or done often.
I thought about requesting to re-name Common Blocks to Essential Blocks or Standard Blocks. However, I realized the issue was more to do with grouping of Editor Inserter Menu.
I realized that I am having hard time navigating through Editor Inserter Menu as a user because the menu is not grouped by “attribution”.
Editor Inserter Menu Right now grouped this way:
My suggestion, grouping by attribution.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
In order to find blocks easily, Editor Inserter Menu needs to be contextualized.
Screenshots
Desktop (please complete the following information):
Additional context
The text was updated successfully, but these errors were encountered: