-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Names and toolbar for alignwide and alignfull are confusing #11881
Comments
Maybe Regarding putting them together in the toolbar, that makes sense to me because if something is full-width it doesn't need to also be left-aligned or right-aligned at the same time and so the choice makes sense to be one or the other and I can see them being grouped because of that (and I see this is a separate argument from them having 'align' in the naming). Note: Typically, with regard to triage, may aim is to review and test without bias (as much unbias as possible!). In this case, I added some opinions above and would like to note they are mine only. I will also add the |
I've gotten used to these but now that you mention it, I too struggled with the difference at first. |
Yeah, but which is which? Full and wide are the same to me. |
Would |
Yes! if that's what it is. |
Although |
It looks like, for the user, the two alignment options are labeled as I definitely understand the argument that they are not alignments, and maybe we can look into how to call them differently. But if this conversation is around how these terms are used in the code, especially for theme developers, then working this change in could get tricky. |
As @mapk's comment shows the tooltips related to width, so, for now, let's close this as it can always be reopened and certainly has feedback. |
I think there is a design problem with GB classes
alignfull
andalignwide
.These are not descriptive of what they are. They are width classes and I can never remember which is which. They have nothing to do with alignment. It is very confusing for a user to see the alignment and width mixture in the toolbar.
The problem is spreading, since themes will have to use these names and now #themereview is proposing adding a filtering tag to the repo called
align-wide
.The documentation will mention the names and have to explain them. I can see how this might be difficult to translate into other languages when it doesn't even make sense in English.
It would be easier to address before 5.0 than after.
The text was updated successfully, but these errors were encountered: