Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paragraph: Misplaced caret when clicking on a Drop Cap-enabled paragraph #12034

Closed
mcsf opened this issue Nov 18, 2018 · 3 comments
Closed

Paragraph: Misplaced caret when clicking on a Drop Cap-enabled paragraph #12034

mcsf opened this issue Nov 18, 2018 · 3 comments
Labels
[Block] Paragraph Affects the Paragraph Block [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended

Comments

@mcsf
Copy link
Contributor

mcsf commented Nov 18, 2018

Describe the bug

Paragraph's "drop cap" feature is only previewed when a block isn't selected (due to poor handling of some browsers when typing in a text field with a drop cap). Thus, when such a block is selected, the drop cap recedes, changing the composition of the text.

Clicking on a block to select it results in the caret being placed where the click happened, and not at the intended text offset.

To Reproduce

See screencast.

Screenshots
drop-cap-caret-misplaced

@mcsf mcsf added [Type] Bug An existing feature does not function as intended [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Block] Paragraph Affects the Paragraph Block labels Nov 18, 2018
@mcsf
Copy link
Contributor Author

mcsf commented Nov 18, 2018

@iseulde: I haven't bisected, but I suspect this is a recent regression stemming from RichText changes. If this is a quick fix, it's worth getting in soon. Otherwise, we can punt.

@mcsf mcsf added this to the 4.5 milestone Nov 18, 2018
@ellatrix
Copy link
Member

I think this has always been an issue?

@mcsf
Copy link
Contributor Author

mcsf commented Nov 19, 2018

Self-closing as duplicate of #11119.

@mcsf mcsf closed this as completed Nov 19, 2018
@ellatrix ellatrix removed this from the 4.5 milestone Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paragraph Affects the Paragraph Block [Feature] Rich Text Related to the Rich Text component that allows developers to render a contenteditable [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants