Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Improve edits reducer's unsetting of merged values #12065

Closed
aduth opened this issue Nov 19, 2018 · 1 comment
Closed

Editor: Improve edits reducer's unsetting of merged values #12065

aduth opened this issue Nov 19, 2018 · 1 comment
Labels
[Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.

Comments

@aduth
Copy link
Member

aduth commented Nov 19, 2018

Related: #10827 (comment)

While handling of nested values (i.e. meta) was improved in #10827, it left a remaining edge case where updated values may be needlessly left in edits state if not all meta values can be considered as updated to their canonical form.

We should consider improving the reducer such that in the handling of UPDATE_POST, if the key for which updates are received is one of the file's EDIT_MERGE_PROPERTIES properties, it should individually unset values from the received canonical value which align, removing the top-level key if all values are the same.

@paaljoachim
Copy link
Contributor

paaljoachim commented Jan 13, 2021

This issue is now really old and I see a PR has been merged.
I will go ahead and close this issue.
@gziolo (I am pinging you in here Greg.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants