Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Interaction: Shift+ArrowUp uncollapsed single-line selection should expand upward #14463

Closed
aduth opened this issue Mar 15, 2019 · 2 comments · Fixed by #14487
Closed
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Mar 15, 2019

Steps to Reproduce:

  1. Navigate to Posts > Add New
  2. Create two paragraphs, each with some amount of text
  3. In the first line of the second paragraph, mark a selection using Shift+ArrowRight
    • image
  4. Without releasing Shift, press ArrowUp

Expected Result:

Selection should adapt corresponding the expected browser + OS behavior of any other multi-line text field. For example, repeat the steps above as two lines in the "Add Comment" section of this GitHub comment box.

In macOS + Chrome: The selection should collapse.
In all other browsers, OS: The selection should expand upward a line. In terms of blocks, I would expect that given the steps above, it would trigger multi-selection to encompass the two blocks.

It's unclear to me, but it seems that as the outlier, the behavior of macOS + Chrome may be buggy for text fields broadly speaking. In which case, "all other browsers" expected behavior may be what we'd want to seek to emulate.

Actual Result:

In macOS + Chrome: The selection collapses.
In all other browsers, OS: The selection reverts to the beginning of the line.

image

Noting that this recently seems to have improved (I suspect as of #14453), where previously nothing at all would happen when pressing ArrowUp.

cc @ellatrix

@aduth aduth added [Type] Bug An existing feature does not function as intended [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... labels Mar 15, 2019
@ellatrix
Copy link
Member

Ah, I get it now. :)

@ellatrix
Copy link
Member

@aduth Fixed it in #14487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants