Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor's ANCHOR_REGEX is incomplete #16165

Open
AlchemyUnited opened this issue Jun 13, 2019 · 2 comments
Open

Anchor's ANCHOR_REGEX is incomplete #16165

AlchemyUnited opened this issue Jun 13, 2019 · 2 comments
Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended

Comments

@AlchemyUnited
Copy link

Describe the bug

afaik, a selector can not start with a digit. According to SO there are some other limitations as well.

https://stackoverflow.com/questions/448981/which-characters-are-valid-in-css-class-names-selectors

The current regex replaces blank/space with '-'. That's it.

Yeah. Minor. But none the less, the "validation" is not sufficient.
@aduth
Copy link
Member

aduth commented Jun 13, 2019

Could you be more specific about what application code of Gutenberg you're referring to here?

@aduth aduth added the [Status] Needs More Info Follow-up required in order to be actionable. label Jun 13, 2019
@AlchemyUnited
Copy link
Author

https://github.com/WordPress/gutenberg/search?q=ANCHOR_REGEX&unscoped_q=ANCHOR_REGEX

@youknowriad youknowriad added [Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later and removed [Status] Needs More Info Follow-up required in order to be actionable. labels Aug 19, 2019
@adamgit adamgit mentioned this issue May 7, 2020
Closed
@paaljoachim paaljoachim mentioned this issue Nov 4, 2020
Closed
13 tasks
@jordesign jordesign added the [Type] Bug An existing feature does not function as intended label Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Priority] Low Used to indicate that the issue at hand isn't a top priority to address and can be handled later [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@youknowriad @aduth @jordesign @AlchemyUnited