Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Custom HTML Anchor for Cover Image Block #17781

Closed
jarretc opened this issue Oct 5, 2019 · 8 comments
Closed

Create Custom HTML Anchor for Cover Image Block #17781

jarretc opened this issue Oct 5, 2019 · 8 comments
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image

Comments

@jarretc
Copy link

jarretc commented Oct 5, 2019

When creating a Heading block, you're allowed to set a custom HTML Anchor within the Advanced block settings. However, when creating a Cover Image block this option isn't available.

@youknowriad
Copy link
Contributor

noting that you ca nest the cover block inside a group block and you can assign an HTML Anchor to the group block.

@adam42a
Copy link

adam42a commented Oct 7, 2019

"Group Block" is not released yet, right? Just surfing around to check the alternatives. Looks like there's currently a plugin that offers a "Section" block. If I made extensive use of such a plugin, I'd have to convert each one manually to a "Group" block when 5.5 comes out, right? Would it best to stay patient? I'm a big fan of keeping it simple.

@youknowriad
Copy link
Contributor

The group block will be included in the upcoming WP 5.3 release. Otherwise, you can just install the Gutenberg plugin in the meantime.

@swissspidy swissspidy added the [Block] Cover Affects the Cover Block - used to display content laid over a background image label Oct 11, 2019
@frogdesk
Copy link

frogdesk commented Feb 7, 2020

The release of the group block, while awesome, does not really solve this problem. Cover still has different functionality from the group block, such as an image background with a fixed position.

IMO, it would be best to give all the cover block functionality to the group block and just combine the blocks, but, either way, it doesn't really make sense to have a block that you cannot give an anchor tag IMO.

@paaljoachim
Copy link
Contributor

Here is an issue that is aiming to add a link to the Cover block.
#12684

Accessibility mentioned a problem of linking the Cover Block (which should be possible to be linked) because of the inline link that can be added. Having a linked item inside another linked item was a big no no as I understood from reading a comment in the above issue..

@youknowriad
Copy link
Contributor

This is actually possible now.

@paaljoachim
Copy link
Contributor

Will this in any way help this issue? (I linked to the comment which basically shut down the issue.)
#12684 (comment)

@youknowriad
Copy link
Contributor

It's unrelated IMO. this just adds an id to the cover wrapper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Cover Affects the Cover Block - used to display content laid over a background image
Projects
None yet
Development

No branches or pull requests

6 participants