Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Cap + alignment produces a gap between paragraphs #18409

Closed
eduardozulian opened this issue Nov 8, 2019 · 0 comments · Fixed by #18831
Closed

Drop Cap + alignment produces a gap between paragraphs #18409

eduardozulian opened this issue Nov 8, 2019 · 0 comments · Fixed by #18831
Assignees
Labels
[Block] Paragraph Affects the Paragraph Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@eduardozulian
Copy link

A combination of a paragraph, a drop cap, and a right/left-aligned image produces a gap between the paragraph with the drop cap and the next paragraph.

To reproduce
Steps to reproduce the behavior:

Add an Image block, and resize the image so it’s about half the width or less of a normal block. For best results, make the image slightly less wide than the screen of your mobile device (or one you'll check in inspect element). I made this image 344x281 px and viewed it via inspect element with the Pixel 2 profile, 411x&731.
Right-align the Image block.
Click below the Image block, in an attempt to add a new block.
See a new Paragraph block appear to the left of the small Image block. Add some text, and use a Drop Cap.

  1. Create a new post using Gutenberg, or use an existing post.
  2. Add a paragraph with a right or left-aligned image that's taller than the paragraph
  3. Choose to use the drop cap option

Expected behavior

To see the text in a good flow. Example:

Captura de Tela 2019-11-08 às 12 06 47

What happened instead

It produces a gap between the first paragraph (with the drop cap) and the second one:

Captura de Tela 2019-11-08 às 12 07 11

This is coming from:

.has-drop-cap:not(:focus):after {
    content: "";
    display: table;
    clear: both;
    padding-top: 14px;
}

Reproduced on both WordPress.com and Jurassic Ninja.

Desktop (please complete the following information):

  • OS: Mac OS
  • Browser: Chrome, Safari, and FF
@jorgefilipecosta jorgefilipecosta added [Block] Paragraph Affects the Paragraph Block [Type] Bug An existing feature does not function as intended labels Nov 21, 2019
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Paragraph Affects the Paragraph Block [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants